Add new Media section to preferences modal #64846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Enhancement
6 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +350 B (+0.02%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0dad32e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10582887608
|
gziolo
approved these changes
Sep 5, 2024
gziolo
reviewed
Sep 5, 2024
| ) } | ||
| > | ||
| <PreferenceToggleControl | ||
| scope="core/media" |
There was a problem hiding this comment.
I must admit that I don't fully understand these scopes, but it seems fine to me for the sake of the experiment. Everything else in the file is core.
There was a problem hiding this comment.
It's essentially just a namespace for grouping similar settings. Other common ones are core/edit-post or core/customize-widgets.
There was a problem hiding this comment.
The scope is used for setting preferences for different packages. core setting was introduced recently for preferences that are on top of editor package (like edit-post and edit-site) and they are shared across these packages. Meaning if you make a change in site editor the same preference will be effective for post editor.
Personally I'd add the in core scope.. --cc @youknowriad
There was a problem hiding this comment.
I would have used the core scope as these are global preferences too but I don't feel very strongly. I think some normalization about these would be good.
There was a problem hiding this comment.
Thank you for providing more details about the scope.
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add new Media section to preferences modal, behind an experimental flag (
window.__experimentalMediaProcessing).Why?
This is for client-side media processing in #61447, which provides some new features such as compressing existing images in the browser. More preferences will likely added in the future as work progresses.
How?
Testing Instructions
Tip: review with whitespace changes hidden, as there's a lot of formatting changes.
Testing Instructions for Keyboard
N/A
Screenshots or screencast