Interactivity API: Fix context inheritance from namespaces different than the current one #64677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Bug
DAreRodz
changed the title
DAreRodz
changed the title
DAreRodz
requested review from
ntwb,
nerrad,
ajitbohra and
luisherranz
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
luisherranz
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
samueljseay
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Aug 21, 2024
30 tasks
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…than the current one (WordPress#64677) * Add failing test * Fix contextStack generation to include other namespaces * Update changelog Co-authored-by: DAreRodz <[email protected]> Co-authored-by: luisherranz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug introduced in the recent refactoring of the Interactivity API internals (see #62734). Noticed while merging
trunkin #62906.Why?
The
data-wp-contextdirective stopped propagating values from parent contexts using a different namespace. This broke directives trying to access values from such contexts.Testing Instructions
These changes can be tested on top of the #62906 PR.
To reproduce the issue:
trunkin the current branch.To check the issue is fixed: