-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Update textControl to searchControl in taxonomy search. #64605
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I think everything about the code is correct, let's get some design feedback.
Before | After |
---|---|
There are visual changes to the field, but I think this is acceptable.
If changes are necessary, I think it would be better to improve it at the component level, as discussed in #56388.
I'd tend to agree with Aki 👍 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too 👍 The label is hidden by default on SearchControl
, but it's still accessibly associated to the input. And with the placeholder and search icon, it's a lot visually clearer that this is a search input, even without the visual label. So I think we're good.
Thanks everyone for your feedback. Let's merge this PR now. @vipul0425 Thanks for the great work! |
…rdPress#64605) Co-authored-by: vipul0425 <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: jasmussen <[email protected]>
What?
Fixes: #64593
Why?
The "Search categories" field in the Post sidebar uses a normal TextControl even though it's a search field.
How?
This PR updates the TextControl component to
SearchControl
in sidebar taxonomy search.Testing Instructions