Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing changes to the changelog for the PR #62734 #64507

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

luisherranz
Copy link
Member

What?

Add missing changes to the changelog for the PR #62734

Why?

We forgot to add them in said pull request.

How?

Simply adding them directly to the changelog file in the latest version.

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Aug 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: luisherranz <[email protected]>
Co-authored-by: SantosGuillamot <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@luisherranz luisherranz added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 14, 2024
@luisherranz luisherranz enabled auto-merge (squash) August 14, 2024 14:31
Copy link
Contributor

@SantosGuillamot SantosGuillamot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙂

I can see there is a bug linked from the pull request: Inability to use plain arrays in context.. Should that be included as well?

By the way, just in case it is useful, there is a GitHub workflow to check if a pull request that needs a backport doesn't have it. Maybe a new one to check the Interactivity API changelog when the package files change could prevent this in the future. Not sure if its worth though 😄

@luisherranz
Copy link
Member Author

luisherranz commented Aug 14, 2024

Maybe a new one to check the Interactivity API changelog when the package files change could prevent this in the future.

I think someone mentioned that it wasn't very useful because not all pull requests need changelog entries.

I can see there is a bug linked from the pull request: Inability to use plain arrays in context.. Should that be included as well?

I don't think it's needed because it's a functionality that should never have been there, although I'm not entirely sure…

@luisherranz luisherranz enabled auto-merge (squash) August 14, 2024 14:40
Copy link

Flaky tests detected in c72b8b7.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10389540841
📝 Reported issues:

@luisherranz luisherranz merged commit 00d1f8a into trunk Aug 14, 2024
65 of 67 checks passed
@luisherranz luisherranz deleted the iapi-update-changelog-for-62734 branch August 14, 2024 15:04
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants