-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing changes to the changelog for the PR #62734 #64507
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙂
I can see there is a bug linked from the pull request: Inability to use plain arrays in context.. Should that be included as well?
By the way, just in case it is useful, there is a GitHub workflow to check if a pull request that needs a backport doesn't have it. Maybe a new one to check the Interactivity API changelog when the package files change could prevent this in the future. Not sure if its worth though 😄
I think someone mentioned that it wasn't very useful because not all pull requests need changelog entries.
I don't think it's needed because it's a functionality that should never have been there, although I'm not entirely sure… |
Flaky tests detected in c72b8b7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10389540841
|
What?
Add missing changes to the changelog for the PR #62734
Why?
We forgot to add them in said pull request.
How?
Simply adding them directly to the changelog file in the latest version.