Repository navigation
FocalPointPicker: Default to new 40px size - #64456
Merged
Merged
Conversation
mirka
added
[Type] Enhancement
28 tasks done
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -25 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Contributor
|
Feels good to see this kind of PRs finally landing 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #46741, #63871
What?
Default the FocalPointPicker to the new 40px size.
Why?
I think this was one of those components where we didn't need to have a transitional period with the
__next40pxDefaultSizeprop. It is a compound component, similar to ColorPicker or TimePicker, which won't cause serious breakage due to the input fields being upsized. The component won't be used in a context where upsizing the inputs would cause overflows, for example.How?
Remove the prop and all it's now-unnecessary usage in the codebase. (All usage in the app was already switched to the 40px size.)
Testing Instructions
Usages of FocalPointPicker should now default to the larger size. Also, having the
__next40pxDefaultSizeprop should not cause TypeScript compilation to fail (only marked as deprecated).