-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Warning and add notice for Navigation #63921
Remove Warning and add notice for Navigation #63921
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AKSHAT2802! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
packages/block-library/src/navigation/edit/deleted-navigation-warning.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AKSHAT2802 thanks for working on this and sorry for the late review. In the issue #59785 I proposed to change only the Warning in the Inspector panel, while this PR changes also the one in the editor canvas. Screenshot:
Also, I'd agree with @Mamaduka that the Notice should not be dismissible.
Could you please have a look and address both points, when you have a chance?
…fix/replace-deleted-navigation-menu-warning-with-notice
Hey @afercia, Addressed both points and updated my PR. This will only change the warning to a non-dismissable notice for the inspector panel. |
packages/block-library/src/navigation/edit/deleted-navigation-warning.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AKSHAT2802 thanks for the update and the screenshot. Looks good to me, I'd only reduce doce duplication. See inline comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AKSHAT2802 thank you. LGTM to me. Can be merged when all tests pass.
Fixes #59785