Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag Cloud: Improve state of block with no tags #63774

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Tag Cloud: Improve state of block with no tags #63774

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60195ce
Render nothing when no tags are available in tag cloud block
akasunil Jul 21, 2024
51881a3
Added condition to display placeholder in editor
akasunil Jul 31, 2024
b1e1d3b
Fix phpcs errors
akasunil Jul 31, 2024
50a8b0d
Merge branch 'trunk' of personal.github.com:WordPress/gutenberg into …
akasunil Aug 21, 2024
63ddb9b
Use wp_is_serving_rest_request function for conditional check
akasunil Aug 22, 2024
323eeac
Merge branch 'trunk' of personal.github.com:WordPress/gutenberg into …
akasunil Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/block-library/src/tag-cloud/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@
);
$tag_cloud = wp_tag_cloud( $args );

if ( ! $tag_cloud ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for chaining ! to empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes code more readable in my opinion. Do you need me to revert it to avoid unnecessary changes?

return '';
if ( empty( $tag_cloud ) ) {
// Display placeholder content when there are no tags only in editor.
if ( ( defined('REST_REQUEST') && REST_REQUEST ) || is_admin() ) {

Check failure on line 34 in packages/block-library/src/tag-cloud/index.php

View workflow job for this annotation

GitHub Actions / PHP coding standards 

Expected 1 spaces after opening parenthesis; 0 found

Check failure on line 34 in packages/block-library/src/tag-cloud/index.php

View workflow job for this annotation

GitHub Actions / PHP coding standards 

Expected 1 spaces before closing parenthesis; 0 found
$tag_cloud = __( 'There’s no content to show here yet.' );
} else {
return '';
}
}

$wrapper_attributes = get_block_wrapper_attributes();
Expand Down
Loading