Fix: The Copy button of the PostURL shouldn't be placed in the slug input

[Rishit30G]

What?

Fixes #63700

Why?

As a user, one would expect the Copy button to copy the value inside the input field, because that's what the UI shows

How?

Change the first parameter in the useCopyToClipboard hook to / + postSlug from permalink

Testing Instructions

• Create a new post
• From settings change permalink to Post Name
• Now go back to the post and on the right panel click on the value part of Link
• Copy the value of the slug by pressing the copy button
• Verify that the value now copied is the slug and not the link to the post

Testing Instructions for Keyboard

Same as above

Screenshots or screencast

Screen.Recording.2024-07-18.at.8.59.40.AM.mov

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Rishit30G <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Rishit30G! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[afercia]

@Rishit30G thank you for your PR. Sorry I wasn't clear. I didn't suggested to change what is copied.
I meant that the Copy button is misplaced. It should be moved close to the value that is actually copied: the full permalink shown below the input field.

[afercia]

See comment.

[Rishit30G]

Hey @afercia!
Thanks for sharing your feedback and insights 🙇
Let me know if this is what was expected:

Screen.Recording.2024-07-19.at.11.00.44.AM.mov

[afercia]

is the <div> necessary?

[Rishit30G]

Yes, as I'm using space-between in styling so it was needed

[afercia]

This description should be adjusted, as this component isn't s 'menu item'.

[Rishit30G]

Sure, can you suggest a better description
Thanks

[afercia]

Thanks for the PR! Yes, this is how the Copy button should be placed. I left some comments, please have a look. I don't think the Input control and the input base components should be changed.

[afercia]

Note: the unit tests are failing because other components e.g. NumberControl use the suffix to add the Increment button. The Suffix prop and component should not be removed from the input control and input base components.

[Rishit30G]

Hey @afercia,
Thanks for sharing your feedback, I have reverted back the changes in the Input Control and Input Base component
Additionally, I have left few comments as well in response to your suggestions
Appreciate your time and efforts