Composite: export new stable version, deprecate unstable version #63364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
changed the title
|
Size Change: -260 B (-0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 08b9b2c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9880931629
|
ciampo
added
[Status] Blocked
ciampo
added
the
has dev note
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
force-pushed
the
feat/composite-ariakit-stabilize
branch
from
16aac5c
to
6ba7ce9
Compare
tyxla
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Thanks for the PR @ciampo 👍
So much work in a single PR though - can make it more difficult to review and test properly 😅
I'd recommend splitting into multiple PRs, for example:
- Export the new stable version
- Remove the v2 from private APIs
- Update consumer components to use the v2
- Deprecate the legacy version
I wonder if there was a reason to prefer doing it all in a single PR?
|
No preference, I thought the size would still be manageable for one unique PR. I will go ahead and split it into smaller ones 👌 |
|
Closing this PR as I will split the changes over smaller PRs. |
ciampo
removed
the
has dev note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #58850
This PR promotes the new private
CompositeV2component family to stable, and marks the "unstable" (legacy) version of the component as deprecated.Why?
The unstable version is using a sub-optimal API layer and is currently not 100% supported. Consumers of the component should migrate to using the new, unprefixed, stable version of
Composite.How?
Compositecomponent from the@wordpress/componentspackage__unstablecomponents as deprecated, and update unit testsCompositeV2private APIs, and update imports across the packageTODO:
Warning
This PR shouldn't be merged until we reach consensus on what naming strategy should be adopted for compounds components.
Testing Instructions
Composite