Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomSelectControlV2: do not flip popover if legacy adapter #63357

Merged
merged 2 commits into from
Jul 11, 2024
Merged

CustomSelectControlV2: do not flip popover if legacy adapter #63357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e48a9
CustomSelectContorlV2: do not flip if legacy adapter
ciampo Jul 10, 2024
31195e6
CHANGELOG
ciampo Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
### Internal

- `CustomSelectControl`: switch to ariakit-based implementation ([#63258](https://github.com/WordPress/gutenberg/pull/63258)).
- `CustomSelectControl`: animate select popover appearance. ([#63343](https://github.com/WordPress/gutenberg/pull/63343))
- `CustomSelectControlV2`: animate select popover appearance. ([#63343](https://github.com/WordPress/gutenberg/pull/63343))
- `CustomSelectControlV2`: do not flip popover if legacy adapter. ([#63357](https://github.com/WordPress/gutenberg/pull/63357)).

### Enhancements

Expand Down
2 changes: 2 additions & 0 deletions packages/components/src/custom-select-control-v2/custom-select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ function _CustomSelect(
sameWidth
slide={ false }
onKeyDown={ onSelectPopoverKeyDown }
// Match legacy behavior
flip={ ! isLegacy }
>
<CustomSelectContext.Provider value={ contextValue }>
{ children }
Expand Down
Loading