Duotone: fix code typo #62953
Merged
Duotone: fix code typo #62953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -14.3 kB (-0.81%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jsnajdr
approved these changes
Jun 28, 2024
andrewserong
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Thanks for the ping!
This fixes the typo, but I think there might still be a bug in useDuotoneStyles. The fix in #55288 had colors in the dependency array for the useEffect that updates blockElement to force a re-render in Safari.
It looks like right now we only have isValidFilter and blockElement in that dependency array, so if we go to update the Duotone colors in Safari, that useEffect isn't called while updating, so the old bug where sometimes Safari doesn't rerender is present:
2024-07-01.15.35.46.mp4
Here's the current dependency array:
If I add colors to it locally, then retesting in Safari with the rest of this PR, the Duotone colors update reliably for me:
2024-07-01.15.44.56.mp4
What do you think?
|
@andrewserong Thanks! The strange thing is that it works the first few time, and then it stop working. I did as you suggested and now it works consistently. |
ellatrix
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 1, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: andrewserong <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: fe20128 |
|
Thanks Ella! 🙇 |
andrewserong
added
the
[Feature] Design Tools
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: andrewserong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Better late than never, I saw the comment by @jsnajdr #56875 (comment)
I mistakenly passed the instance ID as the client ID, which broke the fix from #55288 by @andrewserong.
Why?
Restores the fix from #55288.
How?
Testing Instructions
See #55288.
Testing Instructions for Keyboard
Screenshots or screencast