Fix color remove button in Safari #62698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +23 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
FYI @afercia if you have more context. |
jorgefilipecosta
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Worked very well on my tests, thank you for looking into this issue @ellatrix 👍
ellatrix
added
the
Backport to WP 6.7 Beta/RC
|
I have no idea why this specific icon button seems to behave differently from other buttons in Safari. Are we sure it's the SVG? I can only report that |
It's because, while this button is open, there's also a popover that uses the |
|
@ellatrix I replaced the |
|
Does it work consistently? @jorgefilipecosta Mentioned it can be inconsistent. |
I re-tested it and no, unfortunately it doesn't. To me, it's a matter of timing rather than focus or the SVG. It appears some browsers fire the click event before the button gets removed, while in Safari the button is removed first. I'd argue the root problem is in the design of this UI in the first place. |
ellatrix
force-pushed
the
try/safari-color-button-fix
branch
from
d33a8b7
to
2f6407d
Compare
|
@afercia Completely agree, after testing, it looks like this whole things is completely inaccessible. Once I open the popover, I can't even close it. It looks like this will need a larger refactor to get to work properly, and it feels too late just a few days before RC. Additionally, I wasn't aware that this problem (both the Safari issue and accessibility issue) has existed for a long time. |
|
I'm looking into a complete fix now |
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is an alternative PR to #62628. The problem is that the SVG element is focusable in Safari, which triggers the focus-outside hook (which normally ignores button clicks), so the onClick handler for the button is never called.
Why?
Fixes #62261.
How?
The SVG is already made non focusable, but Safari seems to disobey that attribute.
However,While this worked for me, it didn't seem to work for @jorgefilipecosta. However,disabledworks.pointer-events: 'none'works for both of us. Maybe we should keepdisabled, not sure.Testing Instructions
Use Safari.
Go to Global Styles→ Colors → Palette.
Add a custom color and press Done.
Click the three dots and then "Show details".
Click the button to remove that custom color and see if it works as expected.
Testing Instructions for Keyboard
Screenshots or screencast