Fix issue of HTML entities rendering in command menu #62606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +25 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 11ce7d4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9692083633
|
amitraj2203
added
[Type] Bug
…tenberg into fix/issue-62603
youknowriad
reviewed
Jun 19, 2024
youknowriad
reviewed
Jun 20, 2024
youknowriad
approved these changes
Jun 20, 2024
|
Should this be backported to 6.6? |
|
@youknowriad Should we go ahead and merge it? |
|
@amitraj2203 yes, you have the rights to merge no? I see that some tests didn't run, maybe you need to rebase the PR first. |
I rebased it. Don't know why PHP unit tests are failing since this PR didn't touched any PHP |
|
I'm trying to restart one last time but yeah it looks independent to this PR, maybe network related or something in the different docker repositories we use. (docker, linux...) |
|
Just a small reminder for the next time you merge PRs to include the props in the commit message #62606 (comment) |
|
Sure 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #62603
Why?
When searching for commands containing apostrophes or similar characters, the search results display HTML entities instead of the proper characters. For example,
Test’s &is shown asTest ’s &.Screenshots or screencast
Before:
After:
