[Mobile] Support prefix transforms in mobile #62576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
Mobile App - i.e. Android or iOS
|
Size Change: +5 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eac1559. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9515148245
|
2 tasks
geriux
requested review from
ellatrix,
fluiddot,
dcalhoun and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
geriux
commented
Jun 17, 2024
| @@ -14,7 +14,7 @@ import { | |||
| START_OF_SELECTED_AREA, | |||
| } from '../../../utils/selection'; | |||
|
|
|||
| function findSelection( blocks ) { | |||
| export function findSelection( blocks ) { | |||
There was a problem hiding this comment.
Hey @ellatrix 👋 I was wondering if there would be any concerns about exporting this so the native editor can leverage its functionality?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR adds prefix support in the native editor.
Why?
To allow users to quickly create lists, headings, or quote blocks with different prefixes.
How?
By implementing the Web editor's functionality into the native editor.
Updates the
inputRulefunction with parts of the web's code.Adds a new check within the
onChangeFromAzteccallback within the RichText component to check for input rules.Modifies
getBlockTransformsto allowprefixtypes in mobile.Testing Instructions
Note
Please use the following builds to test:
#,##,###,-,>,1.Heading(Different levels),Quote,List(Numbered, standard)Testing Instructions for Keyboard
N/A
Screenshots or screencast
PrefixTransforms.mov