Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a dedicated autosaves endpoint for handling autosave behavior #6257

Merged
merged 124 commits into from
May 31, 2018
Merged

Introduce a dedicated autosaves endpoint for handling autosave behavior #6257

merged 124 commits into from
May 31, 2018

Commits on Apr 17, 2018

  1. autosaves with rest controller, first pass

    Adam Silverstein committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    9b41d7c View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. use newer title call

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    004c830 View commit details
    Browse the repository at this point in the history

  2. autosave: compare raw attributes for change check

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    9b0a3a4 View commit details
    Browse the repository at this point in the history

  3. Clean up autosave effects

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    b4ad672 View commit details
    Browse the repository at this point in the history

  4. pull isAutosaving from props in PostSavedState

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    aba8548 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    c6d5cce View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    345a508 View commit details
    Browse the repository at this point in the history

  7. from .14

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    bb99f4c View commit details
    Browse the repository at this point in the history

  8. effects, improve toggle autosave timing, enable autosaving for publis… 

    …hed posts
    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    5e85a53 View commit details
    Browse the repository at this point in the history

  9. Disable ‘save draft’ after draft is autosaved

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    491ce55 View commit details
    Browse the repository at this point in the history

  10. revert post saved state changes, keep save button active regardless o… 

    …f autosave status
    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    17a67f6 View commit details
    Browse the repository at this point in the history

  11. remove unrelated showAutosaveAlert

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    81ca0de View commit details
    Browse the repository at this point in the history

  12. fixes for eslint

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    4da3ef1 View commit details
    Browse the repository at this point in the history

  13. leverage withChangeDetection for autosaves

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    b189a3c View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into fix/autosaves 

    # Conflicts:
#	editor/store/effects.js
    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    7769231 View commit details
    Browse the repository at this point in the history

  15. fixes for php slint

    Adam Silverstein committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    d4400a9 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2018

  1. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed Apr 22, 2018
    Configuration menu
    Copy the full SHA
    ab44c63 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    5b0e36d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/autosaves

    Adam Silverstein committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    949557e View commit details
    Browse the repository at this point in the history

  3. rename WP_REST_Autosaves_Controller -> GB_REST_Autosaves_Controller t… 

    …o avoid conflict with core class
    Adam Silverstein committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    e4d20ff View commit details
    Browse the repository at this point in the history

  4. Add a docblock for savePost action

    Adam Silverstein committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    0833e15 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2018

  1. check state.autosave exists before using

    Adam Silverstein committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    6b07e56 View commit details
    Browse the repository at this point in the history

  2. Fix autosave tests

    Adam Silverstein committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    becb66b View commit details
    Browse the repository at this point in the history

  3. Revert "leverage withChangeDetection for autosaves" 

    This reverts commit b189a3c.

# Conflicts:
#	editor/store/selectors.js
    Adam Silverstein committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    ecc1527 View commit details
    Browse the repository at this point in the history

  4. rename rest controler file to match class passing phplint

    Adam Silverstein committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    16ce6f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2018

  1. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    124895b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/autosaves

    Adam Silverstein committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    fd84ca5 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2018

  1. set up isAutosaving

    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    dad5683 View commit details
    Browse the repository at this point in the history

  2. rename controller WP_REST_Autosaves_Controller and only load if class… 

    … doesn’t exist
    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    6c74256 View commit details
    Browse the repository at this point in the history

  3. Cleanup doc blocks

    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    5018748 View commit details
    Browse the repository at this point in the history

  4. rename revision_controller -> revisions_controller

    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    93881fc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    5771f51 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix/autosaves 

    # Conflicts:
#	lib/load.php
#	lib/register.php
    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    7585b00 View commit details
    Browse the repository at this point in the history

  7. clean up isAutosaving reducer, removing toggleAutosave action

    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    ed7d553 View commit details
    Browse the repository at this point in the history

  8. fixes for php-lint

    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    82a1b16 View commit details
    Browse the repository at this point in the history

  9. fix test: button stays in saved state when post not dirty

    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    e02c636 View commit details
    Browse the repository at this point in the history

  10. restore state check

    Adam Silverstein committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    a3c61f7 View commit details
    Browse the repository at this point in the history

  11. Properly instantiate the autosaves controller

    @danielbachhuber
    danielbachhuber committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    a204ece View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. Merge branch 'fix/autosaves' of github.com:WordPress/gutenberg into f… 

    …ix/autosaves
    Adam Silverstein committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    6c4b7a2 View commit details
    Browse the repository at this point in the history

  2. ensure isAutosave returns a boolean

    Adam Silverstein committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    e5e9e25 View commit details
    Browse the repository at this point in the history

  3. Add PHP Unit tests covering WP_REST_Autosaves_Controller functionality

    Adam Silverstein committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    7cd9547 View commit details
    Browse the repository at this point in the history

  4. Avoid duplicate route resgistration

    Adam Silverstein committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    ba0a25f View commit details
    Browse the repository at this point in the history

  5. Rename/fix up unit tests for rest controller

    Adam Silverstein committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    bc79d1f View commit details
    Browse the repository at this point in the history

  6. fixes for phpcs

    Adam Silverstein committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    7a9c123 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2018

  1. Merge branch 'master' into fix/autosaves

    Adam Silverstein committed May 3, 2018
    Configuration menu
    Copy the full SHA
    76e6296 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed May 3, 2018
    Configuration menu
    Copy the full SHA
    5ce9de1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/autosaves 

    # Conflicts:
#	editor/store/effects.js
    Adam Silverstein committed May 3, 2018
    Configuration menu
    Copy the full SHA
    750355f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2018

  1. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed May 4, 2018
    Configuration menu
    Copy the full SHA
    f28f2de View commit details
    Browse the repository at this point in the history

Commits on May 7, 2018

  1. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed May 7, 2018
    Configuration menu
    Copy the full SHA
    b4b95e0 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    b68c7a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/autosaves

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    159d6e0 View commit details
    Browse the repository at this point in the history

  3. document autosave as a parameter property for options

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    9142591 View commit details
    Browse the repository at this point in the history

  4. remove redundant check for isEditedPostNew

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    6e7c57c View commit details
    Browse the repository at this point in the history

  5. rename currentlyAutosaving -> isAutosaving

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    5ee1cae View commit details
    Browse the repository at this point in the history

  6. move autosave reducer outside editor

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    7247780 View commit details
    Browse the repository at this point in the history

  7. set the default autosave state to null

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    193d32e View commit details
    Browse the repository at this point in the history

  8. remove unneded object check that confused logic

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    35f41ee View commit details
    Browse the repository at this point in the history

  9. fix for eslint

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    9af3e3f View commit details
    Browse the repository at this point in the history

  10. ensure href set before using in gutenberg_add_target_schema_to_links

    Adam Silverstein committed May 8, 2018
    Configuration menu
    Copy the full SHA
    e83bdc2 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    dfc22ed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/autosaves 

    # Conflicts:
#	editor/store/reducer.js
#	lib/load.php
#	lib/rest-api.php
    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    00d586a View commit details
    Browse the repository at this point in the history

  3. include the autosaves controller

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    07cccd7 View commit details
    Browse the repository at this point in the history

  4. docblock object -> boolean

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    dbd3ab6 View commit details
    Browse the repository at this point in the history

  5. document isAutosaving reducer

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    4204ad2 View commit details
    Browse the repository at this point in the history

  6. document autosave reducer

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    dfe6bc3 View commit details
    Browse the repository at this point in the history

  7. skip destructuring post

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    6cd8729 View commit details
    Browse the repository at this point in the history

  8. eliminate unneeded conditional

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    7e8b6a2 View commit details
    Browse the repository at this point in the history

  9. rename autosavable -> autosaveable (with an e)

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    bb26c8c View commit details
    Browse the repository at this point in the history

  10. Simplify class check

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    a4eab38 View commit details
    Browse the repository at this point in the history

  11. fixes for phpcs

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    0ca5be0 View commit details
    Browse the repository at this point in the history

  12. savePost on CMD-S

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    d253b12 View commit details
    Browse the repository at this point in the history

  13. correctly return autosave from selector

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    b06eb18 View commit details
    Browse the repository at this point in the history

  14. correct state autosave usage

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    668907b View commit details
    Browse the repository at this point in the history

  15. fix docblock

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    0d1f9b5 View commit details
    Browse the repository at this point in the history

  16. add test: should stop autosave timer when the autosave is up to date

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    92b8d79 View commit details
    Browse the repository at this point in the history

  17. correct test naming: should stop autosave timer when the autosave is … 

    …up to date
    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    376379d View commit details
    Browse the repository at this point in the history

  18. Add an e2e test for post autosaving

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    74935ff View commit details
    Browse the repository at this point in the history

  19. whitespace

    Adam Silverstein committed May 11, 2018
    Configuration menu
    Copy the full SHA
    85a67cd View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. Merge branch 'master' into fix/autosaves 

    # Conflicts:
#	editor/components/post-publish-button/index.js
    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    c81ab2a View commit details
    Browse the repository at this point in the history

  2. respect AUTOSAVE_INTERVAL for autosave timing

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    d795e1d View commit details
    Browse the repository at this point in the history

  3. reset saving state on RESET_AUTOSAVE

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    2531102 View commit details
    Browse the repository at this point in the history

  4. add mu plugin to lower the autosave interval for testing

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    264965d View commit details
    Browse the repository at this point in the history

  5. docs spacing

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    f1df3ff View commit details
    Browse the repository at this point in the history

  6. Add JSDoc for hasAutosave

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    b7042f7 View commit details
    Browse the repository at this point in the history

  7. eslint: missing trailing comma

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    1fe8e20 View commit details
    Browse the repository at this point in the history

  8. Add tests for the hasAutosave selector

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    c31eb05 View commit details
    Browse the repository at this point in the history

  9. remove unused isAutosave in REQUEST_POST_UPDATE_SUCCESS

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    f88fe54 View commit details
    Browse the repository at this point in the history

  10. adjust initial state for autosave test

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    5b5107b View commit details
    Browse the repository at this point in the history

  11. only pass autosaveInterval

    Adam Silverstein committed May 14, 2018
    Configuration menu
    Copy the full SHA
    2012003 View commit details
    Browse the repository at this point in the history

  12. Testing: Trigger programmatic autosave

    @aduth
    aduth committed May 14, 2018
    Configuration menu
    Copy the full SHA
    89131f1 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2018

  1. Merge branch 'fix/autosaves' of github.com:WordPress/gutenberg into f… 

    …ix/autosaves
    Adam Silverstein committed May 15, 2018
    Configuration menu
    Copy the full SHA
    e2e05e5 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2018

  1. Merge branch 'master' of github.com:WordPress/gutenberg

    Adam Silverstein committed May 23, 2018
    Configuration menu
    Copy the full SHA
    3e5e744 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/autosaves 

    # Conflicts:
#	editor/components/post-publish-button/index.js
    Adam Silverstein committed May 23, 2018
    Configuration menu
    Copy the full SHA
    2042645 View commit details
    Browse the repository at this point in the history

  3. revert 2012003

    Adam Silverstein committed May 23, 2018
    Configuration menu
    Copy the full SHA
    bd29ca0 View commit details
    Browse the repository at this point in the history

  4. remove unused className

    Adam Silverstein committed May 23, 2018
    Configuration menu
    Copy the full SHA
    751a47c View commit details
    Browse the repository at this point in the history

  5. use isAutosaving

    Adam Silverstein committed May 23, 2018
    Configuration menu
    Copy the full SHA
    7b1945a View commit details
    Browse the repository at this point in the history

  6. Drop autosave interval back to 10 seconds, because 60 is really slow

    @danielbachhuber
    danielbachhuber committed May 23, 2018
    Configuration menu
    Copy the full SHA
    7fd7c79 View commit details
    Browse the repository at this point in the history

  7. clarify use of isEditedPostSaveable in effects/AUTOSAVE

    Adam Silverstein committed May 23, 2018
    Configuration menu
    Copy the full SHA
    7034cdc View commit details
    Browse the repository at this point in the history

  8. Merge branch 'fix/autosaves' of github.com:WordPress/gutenberg into f… 

    …ix/autosaves
    Adam Silverstein committed May 23, 2018
    Configuration menu
    Copy the full SHA
    20f2b43 View commit details
    Browse the repository at this point in the history

  9. Prevent autosaves if an autosave is in progress.

    Adam Silverstein committed May 23, 2018
    Configuration menu
    Copy the full SHA
    f669754 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. Add isEditedPostSaveable logic to isPostAutosaveable

    Adam Silverstein committed May 24, 2018
    Configuration menu
    Copy the full SHA
    7b4bb19 View commit details
    Browse the repository at this point in the history

  2. autosave monitor tests - use isAutosaveable

    Adam Silverstein committed May 24, 2018
    Configuration menu
    Copy the full SHA
    18e1018 View commit details
    Browse the repository at this point in the history

  3. fix tests for autosave monitor

    Adam Silverstein committed May 24, 2018
    Configuration menu
    Copy the full SHA
    1d40167 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2018

  1. Autosave: Cancel scheduled autosave when autosaving starts

    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    f8724bd View commit details
    Browse the repository at this point in the history

  2. Autosave: Style: Use property shorthand for autosaveInterval assignment

    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    7a3e87b View commit details
    Browse the repository at this point in the history

  3. Revert "revert 2012003" 

    This reverts commit bd29ca0.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    02f5a15 View commit details
    Browse the repository at this point in the history

  4. State: Rename isPostAutosaveable to isEditedPostAutosaveable 

    Consistency with `isEditedPostSaveable`. If we want to simplify, we must simplify both.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    de5c887 View commit details
    Browse the repository at this point in the history

  5. State: Implement isEditedPostAutosaveable as composing `isAutosavin… 

    …gPost`

In case implementation details of detecting whether an autosave is in progress ever change.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    8347b52 View commit details
    Browse the repository at this point in the history

  6. State: Implement autosave action as action creator

    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    66505be View commit details
    Browse the repository at this point in the history

  7. State: Improve isAutosavingPost selector JSDoc 

    Newline between param, return. Full sentence stops. Grammatical consistency of "Returns ..." with other selectors.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    77ce650 View commit details
    Browse the repository at this point in the history

  8. State: Revert doAutosave action creator name to autosave 

    If "save" is a verb, why not is "autosave" ?
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    e0c33c8 View commit details
    Browse the repository at this point in the history

  9. Testing: Avoid potential race conditions on Cmd+S save fail 

    Not guaranteed that notice will not already have been displayed by time Cmd+S press resolves.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    4e82c42 View commit details
    Browse the repository at this point in the history

  10. State: Prevent save request if post is not saveable 

    e.g. New post without content. Previously handled in `AUTOSAVE` handler since keyboard shortcuts executed `autosave` action dispatch.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    5d25123 View commit details
    Browse the repository at this point in the history

  11. State: Implement autosaving as superset of saving condition 

    Simultaneous saves and autosaves should not be allowed, since it opens to race conditions where an explicit save _after_ and autosave occurs could be interpreted by the server _before_ the autosave.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    747f90c View commit details
    Browse the repository at this point in the history

  12. State: Consider save-in-progress as unsaveable 

    Move UI restriction to state consideration, evaluated as part of savePost effect handler.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    dc2e758 View commit details
    Browse the repository at this point in the history

  13. Testing: Evaluate autosave completion by class presence 

    Also eliminate possible race condition on autosave effecting selector prior to resolved evaluation.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    8d5dcf0 View commit details
    Browse the repository at this point in the history

  14. Keyboard Shortcuts: Disallow non-dirty save requests 

    UI restriction previously accounted for by fact that `AUTOSAVE` handler had aborted when post not dirty. This will need to be a future iteration on `savePost` effect.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    83ad219 View commit details
    Browse the repository at this point in the history

  15. State: Track autosave object as subset of received properties 

    Only those used in isEditedPostAutosaveable implementation
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    4821f49 View commit details
    Browse the repository at this point in the history

  16. State: Remove redundant condition from autosaveable 

    Since already checking isEditedPostSaveable, which returns false if save (including autosave) is in progress
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    2dfc666 View commit details
    Browse the repository at this point in the history

  17. State: Simplify isEditedPostAutosaveable as Array#some of fields 

    Consolidate to getEditedPostAttribute as canonical source of fields values
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    102b944 View commit details
    Browse the repository at this point in the history

  18. State: Deprecate getEditedPostExcerpt selector 

    Consolidate to getEditedPostAttribute. Unlike content, there is no special behavior for excerpt. Even if there were, getEditedPostAttribute should be the entry point, which like content, would only then defer its implementation to getEditedPostExcerpt.
    @aduth
    aduth committed May 25, 2018
    Configuration menu
    Copy the full SHA
    563a294 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2018

  1. Merge branch 'master' into fix/autosaves

    @danielbachhuber
    danielbachhuber authored May 31, 2018
    Configuration menu
    Copy the full SHA
    0bec4ea View commit details
    Browse the repository at this point in the history

  2. Remove tests originally removed in bdcbf71 

    These ended up on the wrong side of the merge conflict 0bec4ea
    @danielbachhuber
    danielbachhuber committed May 31, 2018
    Configuration menu
    Copy the full SHA
    f3e564a View commit details
    Browse the repository at this point in the history

  3. Fix linting

    @danielbachhuber
    danielbachhuber committed May 31, 2018
    Configuration menu
    Copy the full SHA
    11f9930 View commit details
    Browse the repository at this point in the history