Fix: Unable to remove custom colors on safari. #62554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +48 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e520dbe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9502486739
|
noisysocks
added
Browser Issues
|
This doesn't seem to fix it for me. I confirmed that the button has a z-index. Kapture.2024-06-14.at.13.56.49.mp4 |
|
It seems the issue is related to the onStopEditing method. It is triggered first, and because it clears the currently edited element, the Remove color method isn't triggered (it relies on That means, the On the other side, the Based on my review, it looks like the hook should be optimized so it doesn't trigger when a child component with an |
|
Thank you for the tests @noisysocks and thank you for the debugging @aatanasovdev. I'm exploring a different fix #62628. |
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #62261
To be honest I don't know the root cause of the issue. It seems to happen only on Safari. I tried many many fixes and this combination of changes seem to work:
cc: @noisysocks and @richtabor in case you can confirm if the issue is also fixed for you.
Testing Instructions
Use Safari.
Go to Appearance → Editor → Colors → Palette.
Add a custom color and press Done.
Click the button to remove that custom color and see if it works as expected.