Skip 'Site Updated' message if only post meta was saved #62284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure of the best way to address this bug. Is the code here on the right track? Modifying Also, I'm unsure if if just checking for I'll keep looking at it, but any thoughts appreciated! |
artemiomorales
added
[Type] Bug
|
Size Change: +26 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 4, 2024
| return await { | ||
| values: dispatch.saveEntityRecord( kind, name, record, options ), | ||
| metaChange: !! edits?.meta, | ||
| }; |
There was a problem hiding this comment.
I don't think we should touch core-data for this change. I think core-data shouldn't have flags like that that are specific to given entities.
| @@ -203,7 +203,7 @@ export const saveDirtyEntities = | |||
| registry | |||
| .dispatch( noticesStore ) | |||
| .createErrorNotice( __( 'Saving failed.' ) ); | |||
| } else { | |||
| } else if ( ! values.every( ( value ) => value.metaChange ) ) { | |||
There was a problem hiding this comment.
metaChange is not the only thing that should prevent the "site updated" notice. I think we should think about this notice a bit more holistically.
Should we show "site updated" when we change just a single entity (like a page or post or a template) or something?
Maybe we should try to be smarter here. If the "pendingRecords" is a single entity we just show ${ entityTitle } saved successfully and if there are multiple records we should "Site updated" or something.
There was a problem hiding this comment.
I decided to try a simpler approach in #63223, related comment here, let me know what you think 🙏
|
I also don't think this is a bug or something that is specific to block bindings or 6.6, so it's probably better addressed outside the 6.6 rush. |
|
An alternative approach might include modifying dirtyEntityRecords and doing a more substantial overhaul inside of saveDirtyEntities, though it seems to me it would be a fairly substantial change. |
|
@youknowriad Great, thanks for the feedback!
@SantosGuillamot What do you think about this? |
|
I agree that we should think more holistically and not think only about post meta changes. Actually, I see it related to what I shared here about triggering the "Save panel" not only for post meta changes but potentially for other things like post description, excerpt... (especially when they have their own block binding source) If we need to work on all of that to solve that issue, I agree that moving it outside 6.6 is probably the best. |
@youknowriad @SantosGuillamot I created an issue to further discuss how we could approach this: #62383 |
artemiomorales
removed
the
Backport to WP 6.7 Beta/RC
|
Since it seems there is a new pull request for the same purpose, should we close this one and keep the discussion there? |
|
Closed in favor of #63223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR aims to avoid rendering the "Site Updated" message if only post metadata in an entity has changed, namely in relation to editing meta via block bindings.
Why?
Addresses #62236
We don't want to erroneously show the "Site Updated" message.
How?
Right now, it adds a flag to
saveEditedEntityRecord()if edits include post meta, and prevents the "Site Updated" message from showing if this is the only kind of edit that occurred.Testing Instructions
1. Register post meta by adding this snippet to your theme's functions.php
2. In the post editor, add a paragraph block bound to the custom field using the Code Editor
Testing Instructions for Keyboard
Screenshots or screencast