Editor: Cleanup styles and classnames #62237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Jun 3, 2024
| @@ -86,13 +85,12 @@ $z-layers: ( | |||
| // Show sidebar above wp-admin navigation bar for mobile viewports: | |||
| // #wpadminbar { z-index: 99999 } | |||
| ".interface-interface-skeleton__sidebar": 100000, | |||
| ".edit-post-layout__toggle-sidebar-panel": 100000, | |||
There was a problem hiding this comment.
In my test this classname was not being used.
youknowriad
commented
Jun 3, 2024
| @@ -468,10 +468,6 @@ $color-control-label-height: 20px; | |||
| top: $admin-bar-height + $header-height + $block-toolbar-height + $border-width; | |||
| } | |||
|
|
|||
| .is-sidebar-opened .wp-block-navigation__responsive-container.is-menu-open { | |||
There was a problem hiding this comment.
this is-sidebar-opened classname was not being added in the site editor (where the navigation block is mostly used) which means that I just removed as this style is probably not useful.
youknowriad
commented
Jun 3, 2024
| 'has-metaboxes': hasActiveMetaboxes, | ||
| 'is-distraction-free': isDistractionFree && isWideViewport, | ||
| 'has-block-breadcrumbs': |
There was a problem hiding this comment.
This was not used.
There was a problem hiding this comment.
We need to keep the has-block-breadcrumbs class to avoid a regression for this one
youknowriad
commented
Jun 3, 2024
| 'has-metaboxes': hasActiveMetaboxes, | ||
| 'is-distraction-free': isDistractionFree && isWideViewport, |
There was a problem hiding this comment.
I moved this class within the component.
youknowriad
commented
Jun 3, 2024
| @@ -206,9 +208,7 @@ export default function EditorInterface( { | |||
| isRichEditingEnabled && | |||
| blockEditorMode !== 'zoom-out' && | |||
| mode === 'visual' && ( | |||
| <div className="edit-post-layout__footer"> | |||
There was a problem hiding this comment.
Removed this div as it was useless in my tests.
There was a problem hiding this comment.
What does "it was useless" mean? https://wpdirectory.net/search/01HZF570S4FPCYK4W9343A277D
There was a problem hiding this comment.
It was useless within Gutenberg.
Looking at the link above, it seems all of the plugins are actually rendering this div and targeting it themselves. They're basically copy/pasting Gutenberg code in their plugins I'd say. So this change won't have any impact on them.
The only one that can be slightly impacted I think is "Virtual Classroom – Video Conferencing & Online Meeting with BigBlueButton". They're hiding the div using CSS.
youknowriad
commented
Jun 3, 2024
| @@ -0,0 +1,3 @@ | |||
| .editor-editor-interface .entities-saved-states__panel-header { | |||
There was a problem hiding this comment.
Move this style from and applied a style that doesn't rely on external classnames.
youknowriad
commented
Jun 3, 2024
| @@ -190,7 +190,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| .is-distraction-free { | |||
| .editor-editor-interface.is-distraction-free { | |||
There was a problem hiding this comment.
This doesn't change anything really but it makes things easier to understand. Relying on global utility classnames is not great because we don't really know who adds the class, the impact...
youknowriad
commented
Jun 3, 2024
| @@ -194,40 +191,34 @@ | |||
| } | |||
| } | |||
|
|
|||
| .edit-post-layout, | |||
| .edit-site-editor__interface-skeleton { | |||
There was a problem hiding this comment.
It was not clear to me why these wrappers were needed, so I just removed them and the publish panel sidebars look the same for me. Am I missing something @ntsekouras
There was a problem hiding this comment.
I don't remember exactly, but I think it was something about the top property for sure and was oriented towards bottom. I tested now and it seemed fine..
There was a problem hiding this comment.
Hey @youknowriad & @ntsekouras 👋🏼 Turns out there's a small regression. I have created a PR, but don't have write permissions yet: #62736
Feel free to take a look. Thank you. 🙂
youknowriad
commented
Jun 3, 2024
| @@ -170,16 +163,6 @@ html.interface-interface-skeleton__html-container { | |||
| @include break-medium() { | |||
| display: flex; | |||
| } | |||
|
|
|||
| .block-editor-block-breadcrumb { | |||
There was a problem hiding this comment.
In my test the breadcrumb looked the same with and without this so I think this was useless (and misplaced anyway)
There was a problem hiding this comment.
Current usage: https://wpdirectory.net/search/01HZF59YSMNJB2CYSYYC08CK8Q
There was a problem hiding this comment.
This class hasn't been removed. It's the style that was removed.
There was a problem hiding this comment.
@youknowriad it looks like this removal has caused a regression in trunk in the post and site editors when no block is selected:
As far as I can tell the display: flex, height and align-items were necessary here, and the left padding helped keep the breadcrumbs from bumping up against the edge of the window.
I've put up a revert PR over in #62309 for just this bit of styling to get it back to what it was. We could then look at moving the CSS elsewhere in a follow-up if there's a better place for it?
carolinan
reviewed
Jun 3, 2024
| @@ -234,7 +234,7 @@ export default function Editor( { isLoading } ) { | |||
| <SiteEditorMoreMenu /> | |||
| <EditorInterface | |||
| className={ clsx( | |||
| 'edit-site-editor__interface-skeleton', | |||
There was a problem hiding this comment.
Looks like WooCommerce uses this class?
https://wpdirectory.net/search/01HZF50T58QDM6WW7MP6WHQ7Y1
There was a problem hiding this comment.
They are actually applying the class them selves, so it should be fine
They probably don't need to apply it at all though, it seems useless looking at their code base.
|
Size Change: -513 B (-0.03%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
juanfra
reviewed
Jun 4, 2024
| 'has-metaboxes': hasActiveMetaboxes, | ||
| 'is-distraction-free': isDistractionFree && isWideViewport, | ||
| 'has-block-breadcrumbs': |
There was a problem hiding this comment.
We need to keep the has-block-breadcrumbs class to avoid a regression for this one
| @@ -185,10 +180,6 @@ export default function Layout() { | |||
| 'is-full-canvas': canvasMode === 'edit', | |||
| 'has-fixed-toolbar': hasFixedToolbar, | |||
| 'is-block-toolbar-visible': hasBlockSelected, | |||
| 'has-block-breadcrumbs': | |||
There was a problem hiding this comment.
We need to keep the has-block-breadcrumbs class to avoid a regression for this one
There was a problem hiding this comment.
We've discussed recently with @jameskoster that the snackbars should remain in the exact same position regardless of what the UI is showing. It's already the case in trunk and this class is not used at all in our styles.
There was a problem hiding this comment.
Thank you. Is there any place I can see the discussion around the topic?
There was a problem hiding this comment.
yes, in this PR #61676
|
Could use an approval here to be able to follow-up with related improvements #62274 |
jorgefilipecosta
approved these changes
Jun 4, 2024
|
Flaky tests detected in 55dbce1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9351583221
|
westonruter
added a commit
that referenced
this pull request
Jun 4, 2024
…dd/on-async-directives * 'trunk' of https://github.com/WordPress/gutenberg: (72 commits) Top toolbar: fix half a pixel artifacting of the bottom border. (#62225) Fix UI order for theme.json spacing sizes (#62199) Chore: Simplify a padding style on global styles. (#62291) Editor: Avoid remounts of `DocumentBar` (#62214) Add `default-spacing-sizes` and `default-font-sizes` options for classic themes (#62252) Editor: Cleanup styles and classnames (#62237) Scripts: Pin the @wordpress/scripts version to a version supported by WP 6.5 (#62234) Documentation: Better changelogs for the JSX transform upgrade (#62265) Chore: Simplify a padding style on dataviews. (#62276) MediaUpload: Remove dialog markup on close (#62168) Tabs: Prevent accidental overflow in indicator (#61979) Make edit site pagination buttons accessibly disabled. (#62267) Fix: Remove unused code from dataviews styles. (#62275) Re-enable React StrictMode (#61943) Inserter: Return the same items when the state and parameters don't change (#62263) Update instances of text-wrap: pretty to fall back to balance (#62233) Update: Slotfill documentation samples (links, code, and rephrase). (#62271) Try: Fix mover positioning. (#62226) [Mobile] - Image corrector - Check the path extension is a valid one (#62190) Update: Block styles documentation. ...
ellatrix
added
the
Backport to WP 6.7 Beta/RC
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: jorgefilipecosta <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: jorgefilipecosta <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: juanfra <[email protected]> Co-authored-by: jorgefilipecosta <[email protected]>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
Both site and post editor pass some classnames to the EditorInterface. The PR intends to unify these classnames as much as possible and cleanup some styles. Users of
EditorInterfacecomponent shouldn't have to provide additional classnames for things to work/show properly.Testing Instructions
See inline comments.