-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privatize an experimental prop for inserter menu #62110
Conversation
Size Change: +754 B (+0.04%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
…omponent directly
It's unclear here what is going on. In the 1st commit I import from the private apis of the block editor package but that somehow builds fine but crashes the private imports in the browser. In the second commit it works, but alas actually it's not InserterMenu but InserterLibrary that should be privatised. Because it is InserterLibrary which is used outside of the block editor package, not InserterMenu which introduces the prop, so the public API comes from InserterLibrary ... But InserterLibrary is already exported as __experimental so ... does that mean anything? Should I drop __experimental now that I make a private version? Do I keep a public experimental component which is different from the private one? |
Closed in favor of #62130 |
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast