Block Variations: Support dot notation in isActive string array
#62088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Enhancement
ockham
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -216 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
May 30, 2024
ntsekouras
approved these changes
May 30, 2024
ntsekouras
added
has dev note
ockham
commented
May 30, 2024
ockham
deleted the
add/get-active-block-variation-nested-object-path-support
branch
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…rdPress#62088) If a block variation's `isActive` property is a `string[]`, support "object paths" (i.e. dot ["property accessors"](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Property_accessors)), such as ```js isActive: [ 'namespace', 'query.postType' ] ``` --------- Co-authored-by: ntsekouras <[email protected]>
49 tasks
justintadlock
added a commit
to x3p0-dev/x3p0-ideas
that referenced
this pull request
Jun 10, 2024
Supported in WordPress 6.6: WordPress/gutenberg#62088
6 tasks
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…rdPress#62088) If a block variation's `isActive` property is a `string[]`, support "object paths" (i.e. dot ["property accessors"](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Property_accessors)), such as ```js isActive: [ 'namespace', 'query.postType' ] ``` --------- Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If a block variation's
isActiveproperty is astring[], support "object paths" (i.e. dot "property accessors"), such asFixes #62068.
Why?
This allows using the
string[]form of theisActiveproperty (rather than afunction) for slightly more complex cases, such asgutenberg/packages/block-library/src/query/variations.js
Lines 41 to 59 in fe40df6
How?
By using the
getValueFromObjectPathutil.Testing Instructions
Do some some testing with block variations in the editor.
Other than that, refer to automated tests.