Fix error when reloading while saving a pattern #62082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6c76bb9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9280653991
|
ellatrix
reviewed
May 30, 2024
| @@ -10,7 +10,7 @@ export function useScrollIntoView( { isSelected } ) { | |||
| if ( isSelected ) { | |||
| const { ownerDocument } = node; | |||
| const { defaultView } = ownerDocument; | |||
| if ( ! defaultView.IntersectionObserver ) { | |||
| if ( ! defaultView?.IntersectionObserver ) { | |||
There was a problem hiding this comment.
What causes defaultView to be null?
There was a problem hiding this comment.
Is this just in test or also manually reproducible?
There was a problem hiding this comment.
There's some more discussion over here - #61941 (comment).
Not entirely sure what causes it, but my best guess is it's a side effect of the page unload, maybe the DOM elements being detached from the DOM.
Not really sure if it's something we need to fix. I just put the PR to demonstrate that the error goes away after this change for that e2e test.
talldan
deleted the
fix/cannot-read-properties-of-null-error-in-pattern-e2e-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #61941
An error is currently happening when running the synced patterns e2e test. It's likely to not cause any user facing issues, but can be addressed.
How?
On this line there's a chance
defaultViewis null-ish, so we should check for that before trying to access theIntersectionObserverproperty in the early return.Testing Instructions
Run the synced patterns e2e tests:
and trigger the
can be inserted after refreshtest case. The error shouldn't happen