Post Sticky Toggle: Improve the design #62012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
update/improve-post-sticky
branch
from
5c3ec04
to
d3e69fa
Compare
|
Size Change: +33 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d3e69fa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9251773653
|
Mamaduka
reviewed
May 27, 2024
Comment on lines
29
to
31
| <VisuallyHidden> | ||
| { __( 'Stick to the top of the blog' ) } | ||
| </VisuallyHidden> |
There was a problem hiding this comment.
I thought most of the components supported the hideLabelFromVision prop.
There was a problem hiding this comment.
Mmm good point, I could update the component to support this prop. 🤔
There was a problem hiding this comment.
It's not a blocker for this PR. Let's create a separate issue for it.
Mamaduka
approved these changes
May 27, 2024
|
If the visual control label is "Sticky", then the accessible name of the control should also be "Sticky". Having a different visually hidden label makes the control harder to use for voice command. Additionally, WCAG 2.5.3 Label in Name requires that the accessible name of a control must contain the visual label, which this does not. If we believe that "Sticky" is sufficient labeling to convey the purpose of this control for sighted users, then it is also sufficient for users of screen readers. |
|
The PR looks good. I believe this enhancement will offer users a more pleasant and improved experience. Thanks! |
youknowriad
force-pushed
the
update/improve-post-sticky
branch
from
cb25507
to
1d77290
Compare
|
This seems like a step in the right direction in that it conforms to the updated summary panel format. I do wonder if it remains a little too prominent though. Something to explore separately could be moving it to the Status dialog. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: joedolson <[email protected]> Co-authored-by: huzaifaalmesbah <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: joedolson <[email protected]> Co-authored-by: huzaifaalmesbah <[email protected]>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Looking at the design of the Post Sticky control in the post editor sidebar, it looks completely broken and out of place compared to the other controls. This PR tries to bring some harmony there.
That said, there's some a11y challenges there, so in order to keep the design correctness while also keeping things accessible, I used a visually hidden label.
Before:
After:
Testing Instructions