-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProgressBar
: Simplify default width
implementation and make it more easily overridable
#61976
Changes from all commits
023e5c4
b1fe7cd
fe9129d
64c72e2
c88ece0
ad0fff9
dc299ed
4c0b8fd
0ff6637
ad2fd28
adf39a1
ceb2840
9b3db94
a219fa8
1d22f24
b096ca4
3af0985
846ccc0
39b92a5
3241379
ff982fb
b0eca3f
59d46cc
0832e40
5ca947a
47183b7
eed1dba
d132170
43e1a57
7a00da3
a9c174b
66e8223
3a95761
a076910
2454c7a
981ce6f
67d97df
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,8 +24,6 @@ export const INDETERMINATE_TRACK_WIDTH = 50; | |
export const Track = styled.div` | ||
position: relative; | ||
overflow: hidden; | ||
width: 100%; | ||
max-width: 160px; | ||
height: ${ CONFIG.borderWidthFocus }; | ||
/* Text color at 10% opacity */ | ||
background-color: color-mix( | ||
|
@@ -38,6 +36,10 @@ export const Track = styled.div` | |
// Windows high contrast mode. | ||
outline: 2px solid transparent; | ||
outline-offset: 2px; | ||
|
||
:where( & ) { | ||
fullofcaffeine marked this conversation as resolved.
Show resolved
Hide resolved
|
||
width: 160px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not specific to this PR, but is there any reason we're not using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've always assumed that this was a "that ship has sailed" situation, since WordPress/Gutenberg is already built entirely on a non-rem basis 😓 |
||
} | ||
`; | ||
|
||
export const Indicator = styled.div< { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thing that's not specific to this PR, but I wonder why we're still using a legacy CSF version, even for new stuff. Haven't checked our current version, but CSF 3 has been supported for the last couple of versions and it makes Storybook much easier to work with. @WordPress/gutenberg-components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should! Nobody hadn't really prioritized it enough.