Make post meta row button treatment consistent #61954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I'm personally leaning towards not eliding. Not strongly. But so long as it's top aligned, and wraps using |
|
Size Change: -42 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
a282328 removes truncation but fixes alignment. I fear this will make the panel feel overwhemling in situations where there are several long labels, but I acknowledge those may be edge cases. It still fixes the underlying issue which is most important as we approach beta. 
|
|
Pushed a small tweak to ensure alignment when the label wraps: 
|
|
Flaky tests detected in d570d65. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9313149576
|
|
Coming back to this one, and keeping in mind we need to make an initial call here, and then we can always revisit, I'd recommend we do this:
|
ntsekouras
reviewed
May 29, 2024
| } | ||
|
|
||
| .components-dropdown, | ||
| .editor-post-author__panel-dropdown { |
There was a problem hiding this comment.
This would be better to be part of the post author component's styles and not part of post panel row.
This will need further investigation and is probably better handled separately. |
|
Thanks for the work. This is very close. In most cases it looks like this:
I had to use the inspector to fake some longer titles and results:
In general, that's good too, though note how we probably need some |
|
Good catch. Pushed a fix: 
This approach uses |
|
The failing tests seem unrelated to this PR 🤔 Perhaps @ntsekouras can take a look? 🙏 |
ntsekouras
force-pushed
the
update/post-meta-buttons
branch
from
9d09693
to
d570d65
Compare
jasmussen
approved these changes
May 31, 2024
|
Thanks all ❤️ |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jasmussen <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #61492 and #61703
What?
Apply the same treatment to all buttons in
.editor-post-panel__row-control. Specifically; truncate to one line, and use a tooltip to display the full value where helpful (IE the date field).Why?
Currently button treatments are inconsistent and in some cases broken. Here's a comparison between trunk and this branch:
It's not uncommon for find long date strings, template names, slugs, author names etc. The UI should be better prepared to handle these scenarios.
Another option to try could be truncating to X number of lines so that details like the full date are always visible, but I prefer truncating to a single line as it keeps the panel neat. The full value is always accessible (either via tooltip, or by opening the associated panel).