Update list layout action styling #61797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jameskoster
added
[Type] Enhancement
|
Size Change: +87 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
May 21, 2024
Yes good spot. I pushed some tweaks to reduce the spacing between title + field values. Also to update the front/posts page badges.
|
|
I think the tests are failing because the buttons are hidden using |
|
@cleacos @madebynoam @lucasmendes-design @jeffgolenski This PR can also impact our usage of the data view component. |
|
Flaky tests detected in 823dc3a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9206916863
|
|
The failing tests here seem to relate to the dropdown component rather than the changes in this PR 🤔 If @ntsekouras or someone from @WordPress/gutenberg-components has time to take a look I'd appreciate it 🙏 |
Attempting the usual suspect fix with waiting for the focus in 9aadc16. |
|
Seems like it's all green and good to go. Disabled the auto-merge because it needs a rebase. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: keoshi <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: keoshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some style details in list layout now that actions have been added.
Align along X axis
This matches table layout and eliminates the uncanny alignment visible on trunk:
Icon color on selected items
This also matches table layout. Specifically: Icon buttons remain
$gray-900when the list item is selected.Improve truncation
When hidden, actions are positioned so that they do not occupy any visual space. This allows the title to span the full width of the row: