Fix Modify content-locked menu item not showing if the block is not selected #61605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Bug
|
Size Change: -19 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Could you check if I'm testing this right? I have a template-locked group block ( 
|
kevin940726
force-pushed
the
fix/modify-content-lock-menu-item
branch
from
77ff827
to
301d04b
Compare
|
Here's what I'm seeing:
It's now called a "Unlock" button in the dropdown. Could you verify if you're also seeing this? |
Yep, I can see that now., thanks!
I'm still unclear about how to test this. I've been comparing trunk to this branch and can't seem to see any difference. What should we be looking for? Here's trunk: Kapture.2024-08-26.at.14.57.46.mp4 |
|
Oops, yeah, It's been too long I forgot what this PR was about 😅. It's about the "Modify" button on the locked group block, not its children. Kapture.2024-08-26.at.14.22.44.mp4 |
|
Got it!
|
ramonjd
approved these changes
Aug 26, 2024
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…elected (WordPress#61605) Co-authored-by: kevin940726 <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Continued from #61127. Fix some issues before and after merging that PR.
Why?
How?
Some minor adjustments, nothing special in terms of code.
Testing Instructions