Open inserter sidebar when clicking on inserter buttons on zoom-out mode #61434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +556 B (+0.03%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
MaggieCabrera
changed the title
ellatrix
reviewed
May 8, 2024
| rootClientId: sectionRootClientId, | ||
| insertionIndex, | ||
| tab: 'patterns', | ||
| category: 'all', |
There was a problem hiding this comment.
We should probably make these private symbols
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
changed the title
|
For what it's worth, I give a ✅ to Ella's changes, let's get someone else's approval too |
This comment was marked as resolved.
This comment was marked as resolved.
|
@jeryj Where do you think focus should go once you click the quick inserter? |
|
Also, it currently does not open the "All" category, when the inserter is already open. We should have it behave consistently, i.e. always open the "All" category. As an aside, it may need to only open the patterns tab, not the a category—but let's get it consistent with "all" first, then we can decide which works better. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
I would say the first focusable within the patterns tab panel. Right now that would be the Pattern Search input.
I think just the pattern tab without the categories open. It's a really big visual jump and easy to lose context of what is happening. Focusing the search when it opens will be a cleaner experience I think. |
ellatrix
force-pushed
the
try-pattern-inserter-2
branch
from
e1f2b05
to
7cc2bda
Compare
|
Flaky tests detected in 9906c57. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8996947065
|
MaggieCabrera
force-pushed
the
try-pattern-inserter-2
branch
from
b0f5bb9
to
7024e02
Compare
ellatrix
reviewed
May 9, 2024
| @@ -41,15 +60,39 @@ function ZoomOutModeInserters( { __unstableContentRef } ) { | |||
| key={ index } | |||
| previousClientId={ clientId } | |||
| nextClientId={ blockOrder[ index ] } | |||
| __unstableContentRef={ __unstableContentRef } | |||
| className="block-editor-button-pattern-inserter" | |||
There was a problem hiding this comment.
Do we still need this class name?
There was a problem hiding this comment.
I don't think so, it can go
|
It's a step forward; not the end-goal. A few notes:
|
|
While ac1bbad enforces patterns to insert after the previous one inserted, it negates the opening of the inserter with the "All" category selected. |
Works well. Thanks! |
ellatrix
approved these changes
May 9, 2024
richtabor
approved these changes
May 9, 2024
|
Hey, @MaggieCabrera The new e2e test introduced here looks to be flaky - #61806. |
I'll look into it as soon as I can |
|
I think I know the cause of the issue: Opening the Pattern tab in the inserter closes the "Styles" sidebar and exits the "zoom-out" mode, and the "Add pattern" buttons are no longer visible. I thought that the Patterns tab in the inserter enabled "zoom-out" mode as well, so I'm not sure if this is a regression in core or just a broken test. cc @draganescu, @jeryj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #61316
Partially addresses #59739
We are exploring not changing the text of the button yet, we want the plus button to instead of opening the quick inserter, it opens the inserter with the patterns tab selected and the All category opened instead.
Why?
In zoom out mode it makes more sense to leverage the full inserter instead of the quick one, since it's a better experience for building with patterns.
How?
We use a Button component instead of the Inserter component to open the inserter sidebar
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast