Fix unlabeled PostURL Copy button. #61195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +5 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #56381 (comment)
This is one more instance where an interactive control is completely unlabeled. There's only an icon. No visitble text, no aria-label, no other labeling. This proves, once again, that some base components can be misused and, in fact, they'r econtinously misused. I would like, once again, to highlight that the sheer amount of cases of unlabeled controls in the hisotry of this project proves the only solid solution to this problem is to make the
labelprop required as requested in #51740Cc @ciampo @ntsekouras @joedolson @alexstine @andrewhayward
What?
The PostURL Copy button is unlabaled.
Why?
All interactive controls must be labeled. Icon buttons, at the very least, must have an aria-label attribute and a tooltip to visually expose their name.
How?
Adds a missing
labelprop to the Button.Testing Instructions
On trunk:
On this PR:
aria-label="Copy"attribute.Testing Instructions for Keyboard
Screenshots or screencast