-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notices: Fix snackbar placement #60912
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -627 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the code I think the has block breadcrumbs class should apply on a condition that also includes distraction free mode so that we don't check the is distraction free mode in CSS via not
, instead only looking if the marker class has-block-breadcrumbs
is preset. What do you think?
Thanks for the review, Andrei! Sounds good, I'll update the PR. |
… not in distraction-free mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good now, thank you! 🙇🏻
As a nit I wonder if for saying:
- apply the breadcrumbs class
- if the breadcrumbs preference is on
- if distraction free is off
- if is wide viewport
- if canvas mode is edit
we're better using all unioned conditions
e.g. instead of
hasBlockBreadcrumbs && ( ! isDistractionFree || ! isWideViewport ),
use
hasBlockBreadcrumbs && ! isDistractionFree && isWideViewport,
and
hasBlockBreadcrumbs && ( ! isDistractionFree || canvasMode !== 'edit' ),
use
hasBlockBreadcrumbs && ! isDistractionFree && canvasMode !== 'edit' ,
,
is easier to read. Unless I am borking the condition in my head?
Thanks, Andrei! Yes, that will make things more readable. I'll push the changes. The second should be |
What?
Fix snackbar placement for distraction-free, and when blocks breadcrumbs is not enabled.
Fixes #53198
Why?
When the editor was in distraction-free mode, or when the blocks breadcrumbs were disabled
How?
Adding a class to the wrapper when the editor has block breadcrumbs enabled, and playing with CSS. I went with a bottom of 16px to follow the other paddings applied to the snackbar, and because the computed height of the blocks breadcrumb is 24px.
Testing Instructions
Site Editor
Post/Page editor
Screenshots or screencast
Screen.Recording.2024-04-19.at.18.21.53.mov