ComboboxControl: Simplify string normalization #60893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
commented
Apr 19, 2024
| ].join( '' ) }]`, | ||
| 'g' | ||
| 'gu' | ||
| ); | ||
|
|
||
| export const normalizeTextString = ( value: string ): string => { |
There was a problem hiding this comment.
FWIW this function is used only in ComboboxControl. Should we just inline it there?
|
Size Change: -99 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Apr 19, 2024
tyxla
force-pushed
the
update/simplify-component-string-normalization
branch
from
ef9cd75 to
8aa81e9
Compare
tyxla
force-pushed
the
update/simplify-component-string-normalization
branch
from
8aa81e9 to
484a3d0
Compare
|
The react native e2e tests on iOS are consistently failing, I'll investigate and try different things out to see what's going on. |
tyxla
force-pushed
the
update/simplify-component-string-normalization
branch
from
fa16e0f to
5431024
Compare
tyxla
force-pushed
the
update/simplify-component-string-normalization
branch
from
2e0e7e0 to
b56d28b
Compare
Okay, got it! Seems like Hermes doesn't support the Unicode character groups (yet), see:
Luckily, it supports the literal regex notation (flags in the first argument of the `RegEx constructor), so I've refactored to that. I've also added some comments to make it all clearer. @Mamaduka could you have another look when you get a chance? Thanks 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR simplifies the string normalization, performed on the user input of
ComboboxControl.Why?
For simplicity, brevity, and better coverage of dash characters that we might have missed.
How?
We're using the dash punctuation character class
\p{Pd}that covers the most explicitly listed characters.We're also moving all original characters to the unit test to ensure clarity, full backward compatibility, and better documentation that sets the right expectations.
Testing Instructions
All tests should still pass.
Testing Instructions for Keyboard
None
Screenshots or screencast
None