Repository navigation
Editor: Serve as a proxy for the interface package - #60748
Merged
Merged
Conversation
youknowriad
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -5.1 kB (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jsnajdr
reviewed
Apr 16, 2024
youknowriad
force-pushed
the
update/import-interface-through-editor
branch
from
April 16, 2024 09:39
5dcc585 to
3bba509
Compare
ntsekouras
approved these changes
Apr 16, 2024
ntsekouras
left a comment
ntsekouras
left a comment
Contributor
There was a problem hiding this comment.
I smoke tested the editors and didn't notice anything different.
youknowriad
enabled auto-merge (squash)
April 16, 2024 09:55
youknowriad
disabled auto-merge
April 16, 2024 10:00
youknowriad
enabled auto-merge (squash)
April 16, 2024 10:00
oandregal
disabled auto-merge
April 16, 2024 10:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #52632
What?
As you align editor APIs between post and site editors, we'll have to align extensibility APIs that rely on the interface package.
This package is a bundled package (bundled within the package that import it) and it also defines a store, which means it can't be imported both from "editor" and "edit-post" at the same time. (Triggers an error about double store).
I think having a "store" in this package was an error that we made a long time ago, so it's hard to change now in one go, so in order to avoid this issue, we can make the editor package work as a proxy for the "interface" package APIs for both edit-post and edit-site.
So the current PR does exactly that to allow us to make further unification as follow-ups.
Testing Instructions
There should be no functional change, it's mostly about moving things around.