-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Media & Text block displays video upload errors #59288
fix: Media & Text block displays video upload errors #59288
Conversation
When the paused state and messaging was implemented for image uploads, it was inadvertently applied to Media & Text blocks. This resulted in a lack of any failed upload messages when a video was attached to the Media & Text block.
Size Change: -43 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Flaky tests detected in f7cea0c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8008159913
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for adding a test. 🚀
What?
Fix the absence of an error message whenever a video upload for the Media & Text
block fails.
Why?
Fixes #59247. The missing error message leaves the user in a confusing state.
How?
Only enabled the paused media state for image media, which was the original
intent in #56937.
Testing Instructions
Tip
Use a prototype build: iOS or Android.
Testing Instructions for Keyboard
N/A, no changes to the flow included.
Screenshots or screencast
Not provided.