Font Library: make font collection fields translatable

[matiasbenedetto]

What?

Porting changes back from WordPress core PR already merged: WordPress/wordpress-develop#6130

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <[email protected]>
Co-authored-by: vcanales <[email protected]>
Co-authored-by: creativecoder <[email protected]>
Co-authored-by: pbking <[email protected]>
Co-authored-by: getdave <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-collections-controller.php
❔ lib/compat/wordpress-6.5/fonts/fonts.php

[github-actions]

Flaky tests detected in c79602f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8002415091
📝 Reported issues:

• [Flaky Test] submenu converts to link automatically #58981 in /test/e2e/specs/editor/blocks/navigation.spec.js

[vcanales]

LGTM

[creativecoder]

All of these strings need the 'gutenberg' text domain as well.

[matiasbenedetto]

added here: 450f9f5

[pbking]

If I pull out the category from the collection it's missing from the drop down. (Above Sans Serif was removed.) I suspect that's as-expected, and that's similar behavior to before this change. But with the category specifics now being provided separately from the font face assignment to those collections I just wanted to make sure.

If the above is as expected then this tests well for me.

[matiasbenedetto]

If I pull out the category from the collection it's missing from the drop down.

@pbking yes, that's expected.

[creativecoder]

Thanks for adding the domain to the new text strings.

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: [Type] Enhancement, Backport from WordPress Core, [Feature] Font Library.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[getdave]

I rebased this and now hopefully all the tests will be ✅ and auto merge will handle.