-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce section container selection when assembling patterns (zoom out mode) #59249
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
42cedd0
Zoom Out: Only enable the zoom-out mode within the main group
youknowriad 5b8a035
Hide inner blocks if block has active overlay
getdave 20b540e
Account for assembling pages by using post content block as section c…
getdave d191f7a
use maybedisable as a name for the disabling component
draganescu 627ad0d
Refactor components to hooks
ajlende 83d6680
rebase fix missed isZoomedOutView changes in trunk
draganescu ccffdf4
don't spread the client ids
scruffian 5869fb8
create a new selector to find the root section block name
scruffian 1e1db1f
correct some variable names, remove testing code
draganescu 4c49ed7
remove useless call to function in the editor package
draganescu 8b924fa
remove the useEffect in the editor component of edit site, use the ac…
draganescu ada6ff7
WIP Refactor hook to store action
ajlende 53b2ef1
Fix copy/paste mistake
ajlende 8906c33
combine state and modes in the reducer correctly into one iterable
draganescu d68bb3a
enable selection for no root section block
draganescu bb01ba4
enable section selection for sections when there is no root section c…
draganescu 61b9078
Use registry.batch instead
ajlende a828c9c
Replace bulk actions with registry.batch
ajlende 212d638
make section root selector and action private
draganescu 4d8c43c
dispatch set block mode action
draganescu 207126a
privatize the section root block client id selector
ajlende 79d8af4
Remove unused reducers
ajlende 120aa93
Refactor to group by if we have a sectionsContainerClientId
ajlende 206e17d
Add wrapper to prevent running a bunch of loops in non-zoom out modes
ajlende 90a4634
Move SET_EDITOR_MODE back to the end so prevMode works
ajlende c7a2cc0
Add comments for two main sections
ajlende 9f3d560
Use constant instead of random empty string
ajlende b289f6d
Revert remaining block-list changes
ajlende cab518b
Refactor to use select
ajlende de412a9
Refactor to use ROOT_CONTAINER_CLIENT_ID instead of empty string
ajlende 5162d0c
Move zoom-out logic to selector instead of action
ajlende 37c477c
Remove registry.batch
ajlende 80e67b5
Update JSDoc for ROOT_CONTAINER_CLIENT_ID defaults
ajlende 3a59a10
Revert pattern edit.js
ajlende ebed90c
Fix selectors in selectors
ajlende 2528ce9
Fix selection when entering zoom-out mode
ajlende c5816f2
Fix case wher getBlock returns null
ajlende fb41e16
Optimize selector some more
ajlende b1ccce7
Fix missing imports
ajlende 5d0a81a
Revert ROOT_CONTAINER_CLIENT_ID rename
ajlende 9e5640a
Revert list-view changes
ajlende dfc8f1e
Try moving post type logic into useBlockEditorSettings
ajlende d632363
Try make sectionRootClientId a private setting
ajlende 4febcf8
Remove unused code
ajlende e5bafcc
Fix selected block in zoom out mode
ajlende 29399fd
Rename _settings to blockEditorSettings
ajlende 3af6938
Remove destructuing
ajlende a9529ac
make templates with no root also work
draganescu cb04e38
Check block list for active block overlay
ajlende 6c2b78f
Pass rendering mode instead of type
ajlende 640823f
Fix an issue where some selectors pass null as a default value instea…
ajlende fd8cf0a
Try disabling all non-children of the sectionRoot
ajlende b96f5a6
don't put overlay on all blocks in zoom out, just root and section ch…
draganescu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to be declared here if it's locked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it doesn't need to be declared here if it isn't part of the parent settings that we want to include.