env: Fix mariadb version to LTS #59237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
the
[Type] Bug
swissspidy
reviewed
Feb 21, 2024
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 8d48730. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7989268543
|
|
I can confirm that for the learn.wordpress.org local development environment built on top of wp-env, this fix does allow wp-env to start. |
|
Works for me! Thanks @t-hamano |
|
This approach seems to work. I think that the reason why the performance test fails is because wp-env does not start on trunk. |
swissspidy
approved these changes
Feb 21, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @deanpienaar, @dmaziar, @adimoldovan, @ramonschriks, @sweber83. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Feb 21, 2024
|
Okay, let's merge this. |
|
The "Compare performance width base branch" performance test seems to fail on trunk. Is this because the base branch still references the latest version of |
|
I think so, yes. It will work again once MariaDB push out a new version, which should be fairly soon I imagine |
eason9487
added a commit
to woocommerce/google-listings-and-ads
that referenced
this pull request
Feb 22, 2024
…he default charset change in MariaDB v11.3.1. Ref: - https://jira.mariadb.org/browse/MDEV-32975 - WordPress/gutenberg#59237
dmaziar
pushed a commit
to elementor/elementor
that referenced
this pull request
Feb 22, 2024
Reverts #25223 and upgrades `wp-env` to 9.4.0 which uses MariaDB LTS instead of latest WordPress/gutenberg#59237 --------- Co-authored-by: ElementorBot <[email protected]>
Nevoss
pushed a commit
to Nevoss/elementor
that referenced
this pull request
Feb 24, 2024
Reverts elementor#25223 and upgrades `wp-env` to 9.4.0 which uses MariaDB LTS instead of latest WordPress/gutenberg#59237 --------- Co-authored-by: ElementorBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the connection failure to the database by pinning the version of mariadb to LTS and testing if GitHub Actions pass.
Please check this out for details: https://wordpress.slack.com/archives/C02QB2JS7/p1708499504613749
Fixes #59232
Why?
There seems to be a problem with the latest version of the
mariadbimage, as seen in the issue below.MariaDB/mariadb-docker#560
How?
Pin the image version to
lts.Testing Instructions
Hopefully, wp-env should now start successfully and pass GitHub Actions successfully.