DocumentBar: Fix browser warning error #59193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +7 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 24319ea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7969281254
|
ramonjd
approved these changes
Feb 20, 2024
|
@ramonjd Thanks for the review! |
|
There's probably a bug with If you want to avoid the extra CSS you could try |
cc @mirka and @andrewhayward since Marco's currently on leave. |
Thanks for flagging! Fix in #59416. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #58656
What?
This PR fixes the browser warning error when the canvas is the edit mode.
7b4520c33ebf97f68bc5da94b940a8d7.mp4
Why?
The error logged in the browser console is as follows:
Details
It seems that for some reason the DOM element is given an incorrect prop called
isColumn. Using React Dev Tools, you can see that theViewcomponent, which is rendered as a div element, is given a prop calledisColumn.How?
To be honest, I haven't been able to pinpoint the root cause, but in most cases it seems that the
motion.divitself is being used as a component instead of passing itasprop. In fact, this approach solved the console error.Testing Instructions