Fix logic error in #58951 #59101
Merged
Fix logic error in #58951 #59101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
matiasbenedetto
added
the
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 886828d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7920594154
|
andrewserong
added
the
Backport to WP 6.7 Beta/RC
|
@matiasbenedetto Thank you for the quick fix 🙇 |
aristath
added a commit
that referenced
this pull request
Feb 16, 2024
* trunk: (78 commits) Components: Use `Element.scrollIntoView()` instead of `dom-scroll-into-view` (#59085) DataViews: Correctly display featured image that don't have image sizes (#59111) Elements: Fix block instance element styles for links applying to buttons (#59114) Allow editing of image block alt and title attributes in content only mode (#58998) Add toggle for grid types and stabilise Grid block variation. (#59051) Global Styles: fix console error in block preview (#59112) Navigation: Avoid using embedded records from fallback API (#59076) Refactor responsive logic for grid column spans. (#59057) Editor: Unify Mode Switcher component between post and site editor (#59100) Move StopEditingAsBlocksOnOutsideSelect to Root (#58412) Fix logic error in #58951 (#59101) Block-editor: Auto-register block commands (#59079) Fix small typo in rich text reference guide (#59089) Components: Add lint rules for theme color CSS var usage (#59022) Enter editing mode via Enter or Spacebar (#58795) Updating Storybook to v7.6.15 (latest) (#59074) CustomSelectControl (v1 & v2): Fix errors in unit test setup (#59038) Add stylelint rule to prevent theme CSS vars outside of wp-components (#59020) ColorPicker: Style without accessing InputControl internals (#59069) Pattern block: batch replacing actions (#59075) ...
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
* fix empty font sizes * fix logic error Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: scruffian <[email protected]>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: ecb9f52 |
getdave
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
* fix empty font sizes * fix logic error Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: scruffian <[email protected]>
creativecoder
added
the
Global Styles
|
Note that as part of curating the Gutenberg 17.8 changelog, I added the label Global Styles to this PR to better categorize it. Please let me know if there is a different label that would be a better fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix regressions produced by logic errors introduced in #58951
Why?
Example of the logic error:
If
fontSizesis an empty objectoverrideOrigins( fontSizes )will beundefinedand theforloop will break.This pattern repeats a few times in #58951
How?
Fixing the logic
Testing Instructions
Screenshots or screencast
Before:
2024-02-15.14-57-22.mp4
After:
2024-02-15.15-13-15.mp4