feat: Toggle mobile Quote block citation #59097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the native `RichText` implementation relied upon a bespoke `setRef` prop to forward refs to the native rich text editor instance (i.e., Aztec). While this worked fine for contexts where `RichText` was used for the native platform only, it diverged from the web `RichText`. This divergence created incompatibility for the context of a component running on both web and native which passed a ref to `RichText`. This refactor aligns the native `RichText` with the web implementation so that refs may be passed under a single, unified `ref` prop. The ref is then forwarded onto the native rich text editor instance, as it was before.
The `display: block` style attribute is not supported by React Native and results in an error.
The citation input is now hidden behind a toggle button.
dcalhoun
added
[Type] Enhancement
|
Size Change: -4 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Align with the web implementation by hiding the citation input behind a toggle button.
dcalhoun
removed
the
[Type] Breaking Change
|
Flaky tests detected in 075a308. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7919722143
|
dcalhoun
added
the
Mobile App - Automation
dcalhoun
requested review from
ellatrix,
fluiddot and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Toggle the Quote block citation visibility with a button.
Why?
Align with the web editor's approach for citations and captions.
How?
refactor: Align
RichTextrefs with web implementationPreviously, the native
RichTextimplementation relied upon a bespokesetRefprop to forward refs to the native rich text editor instance(i.e., Aztec). While this worked fine for contexts where
RichTextwasused for the native platform only, it diverged from the web
RichText.This divergence created incompatibility for the context of a component
running on both web and native which passed a ref to
RichText.This refactor aligns the native
RichTextwith the web implementationso that refs may be passed under a single, unified
refprop. The refis then forwarded onto the native rich text editor instance, as it was
before.
fix: Avoid passing incompatible styles to native components
The
display: blockstyle attribute is not supported by React Nativeand results in an error.
test: Fix Quote block citation interaction
The citation input is now hidden behind a toggle button.
feat: Toggle Pullquote block citation
Align with the web implementation by hiding the citation input behind a
toggle button.
Testing Instructions
block.
The above steps can be repeated (sans step 3) for a Pullquote block as well.
Lastly, regression testing of the post title field and Button block are helpful as the refactor modified those modules.
Testing Instructions for Keyboard
Perform the aforementioned testing instructions while navigating with a screen reader.
Screenshots or screencast
Screen recording
quote-citation.mp4