Background image support: Fix issue with background position keyboard entry #59050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard entry happens before mouse interaction
andrewserong
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +11 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c3cd8ce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7910787583
|
tellthemachines
approved these changes
Feb 15, 2024
|
Thanks for the quick review! 🙇 |
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
…ard entry happens before mouse interaction (#59050) Co-authored-by: andrewserong <[email protected]> Co-authored-by: tellthemachines <[email protected]>
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 9b48e86 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added
the
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
…ard entry happens before mouse interaction (#59050) Co-authored-by: andrewserong <[email protected]> Co-authored-by: tellthemachines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #54336
Fix keyboard entry for the background image block support's position controls.
Why?
If a user has not yet interacted with the background position controls via the mouse, then when entering a number in one of the "left" or "top" fields, we need to update the opposing side to a default value, otherwise it is set to
NaNand fails to update the block attributes.Currently, for folks entering numbers by keyboard and not interacting via the mouse, it's impossible to set any values.
How?
0.5(50%) so that the controls become usable again.Testing Instructions
trunk, note that once you tab out of the field, the value does not stick. With this PR applied, when you add a value, the empty value on the other side should default to50%.Testing Instructions for Keyboard
As above.
Screenshots or screencast
Trunk
2024-02-15.14.27.04.mp4
This PR
2024-02-15.14.25.06.mp4