Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Update docs guide with new wp-interactivity directive implementation. #59018

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

cbravobernal
Copy link
Contributor

What?

#58743 added support for setting the namespace with just a string in data-wp-interactive. In this PR, I updated the docs accordingly.

Copy link

github-actions bot commented Feb 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: c4rl0sbr4v0 <[email protected]>
Co-authored-by: SantosGuillamot <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 14, 2024

Flaky tests detected in b7f6519.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7902435264
📝 Reported issues:

Copy link
Contributor

@SantosGuillamot SantosGuillamot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

These are a few more places where it could make sense to update it:

  • Getting started guide: link.
  • Hooks comments: link.
  • Store comments: link.

@cbravobernal
Copy link
Contributor Author

  • Getting started guide: link.
  • Hooks comments: link.
  • Store comments: link.

Will do in follow-up PRs. Thanks Mario!

@cbravobernal cbravobernal enabled auto-merge (squash) February 14, 2024 16:44
@cbravobernal cbravobernal merged commit 6d3e24a into trunk Feb 14, 2024
64 checks passed
@cbravobernal cbravobernal deleted the update/interactivity-api-docs-guide branch February 14, 2024 17:00
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Packages] Interactivity /packages/interactivity [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants