Editor: Do not open list view by default on mobile #59016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Feb 14, 2024
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: -87 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9e3a47e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7913375204
|
ntsekouras
approved these changes
Feb 14, 2024
aaronrobertshaw
approved these changes
Feb 15, 2024
andrewserong
approved these changes
Feb 15, 2024
|
In what may be a very rare scenario, if I follow the steps below, the list view will not be displayed by default.
Is it not possible to use a Also, although this may be outside the scope of this PR, I thought it would be nice to have a process to hide the list view when switching from desktop view to mobile view. |
|
I think personally resizing viewport is not something users do while using an app in general, so I don't think it's something to really account for. |
youknowriad
added a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: t-hamano <[email protected]>
youknowriad
added
Backported to WP Core
youknowriad
added a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: t-hamano <[email protected]>
creativecoder
added
the
[Feature] List View
|
Note that as part of curating the Gutenberg 17.8 changelog, I added the label [Feature] List View to this PR to better categorize it. Please let me know if there is a different label that would be a better fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the editor (post and site) we have a preference that indicates whether we should open the list view by default or not.
In some very small viewport the list view button is not even available so taking this preference into consideration in smaller viewports doesn't make sense.
This PR makes this preference only work for desktops.
Testing Instructions
1- Check the "open list view by default" preference
2- Open the editor on mobile
3- The list view shouldn't be open by default.