Components: Try fixing some flaky Composite and Tabs tests
#58968
Conversation
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -275,7 +275,7 @@ describe.each( [ | |||
| const { item2 } = getOneDimensionalItems(); | |||
|
|
|||
| await press.Tab(); | |||
| expect( item2 ).toHaveFocus(); | |||
| await waitFor( () => expect( item2 ).toHaveFocus() ); | |||
There was a problem hiding this comment.
Perhaps some sleep() before the Tab() (as suggested here) would be a good improvement too?
There was a problem hiding this comment.
Yes, that might help. The Tabs test was fine, but I could still get this Composite one to flake.
| @@ -275,7 +275,7 @@ describe.each( [ | |||
| const { item2 } = getOneDimensionalItems(); | |||
|
|
|||
| await press.Tab(); | |||
| expect( item2 ).toHaveFocus(); | |||
| await waitFor( () => expect( item2 ).toHaveFocus() ); | |||
There was a problem hiding this comment.
Yes, that might help. The Tabs test was fine, but I could still get this Composite one to flake.
tyxla
force-pushed
the
try/fix-flaky-composite-tabs-tests
branch
from
e3176eb
to
1eb47f2
Compare
|
Flaky tests detected in 1eb47f2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7900653318
|
|
Another flaky test failure on |
creativecoder
added
[Type] Automated Testing
What?
This PR adds some flexibility to a few
CompositeandTabstests.Why?
To reduce the test flakiness.
How?
We're adding some wait time before checking focus right after tabbing.
Testing Instructions
Verify all tests pass.
Testing Instructions for Keyboard
None
Screenshots or screencast
None