-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules API: Script Modules add deregister option. #58830
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/interactivity-api.php ❔ lib/compat/wordpress-6.5/class-wp-script-modules.php ❔ lib/compat/wordpress-6.5/scripts-modules.php ❔ lib/load.php |
5c1a8f5
to
1d71612
Compare
Flaky tests detected in 1d71612. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7918228996
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do we need a backport label for this PR? |
No, because this brings a change from core to Gutenberg. |
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
I've added the backport label to make sure this code is also in wp/6.5 branch. |
* Add deregister module function * Sync with core PR
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 1605148 |
* Add deregister module function * Sync with core PR
What?
Syncs WordPress/wordpress-develop#6061 in Gutenberg, to be compatible with WordPress < 6.5
Updates the patch for loading Gutenberg Interactivity API script module instead of Core one.
Why?
Consistency with
wp_deregister_style
orwp_deregister_script
. To be able to override script modules.How?
Testing Instructions
Gutenberg version of Interactivity API should be loaded in WP 6.4, 6.5 with this PR merged.