Migrate change-detection to Playwright
#58767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
kevin940726
requested review from
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
kevin940726
commented
Feb 7, 2024
|
|
||
| await assertIsDirty( true ); | ||
|
|
||
| expect( console ).toHaveErroredWith( |
There was a problem hiding this comment.
This is left out in the migrated test since this is browser-dependent. I don't think it provides much value to the test.
| expect( | ||
| isCurrentURL( | ||
| '/wp-admin/edit.php', | ||
| `post_type=post&ids=${ postId }` |
There was a problem hiding this comment.
This is actually wrong. isCurrentURL only returns false when the url is not a WP url, it doesn't check the query params for some reason. The final url also doesn't include the ids=${postId} part either.
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
Mamaduka
reviewed
Feb 7, 2024
Comment on lines
518
to
522
| const hasDialog = new Promise( ( resolve ) => { | ||
| this.#page.on( 'dialog', ( dialog ) => { | ||
| void dialog.accept(); | ||
| resolve( true ); | ||
| } ); | ||
| this.#page.on( 'load', () => resolve( false ) ); | ||
| } ); | ||
| await this.#page.reload( { waitUntil: 'commit' } ); // No need to wait for the full load. | ||
| return hasDialog; |
There was a problem hiding this comment.
This is very interesting. Based on docs, PW only handles beforeunload dialogs when calling page.close({ runBeforeUnload: true }). They aren't run on page.reload, so I'm really curious how this assertion is working 😅
There was a problem hiding this comment.
I couldn't find the part where the doc is referencing that though. I think the doc means that it won't wait for the beforeunload dialogs unless runBeforeUnload is true. But that's just for page.close(). beforeunload dialogs should still be available in the event handler, but since we don't care whether Playwright waits for the dialog to be closed or not, I think this is fine?
There was a problem hiding this comment.
Here's the link - https://playwright.dev/docs/dialogs#beforeunload-dialog. You're right; this doc probably refers to page leave context.
I think this is fine?
As long as assertions work, it's golden 😄
|
Seems like the unit tests for PHP are failing for a known issue in core. |
Mamaduka
force-pushed
the
migrate/change-detection-playwright
branch
from
8372766
to
a05a995
Compare
Mamaduka
reviewed
Feb 9, 2024
Comment on lines
+542
to
+543
| ( url ) => | ||
| POST_URLS.some( ( postUrl ) => url.href.includes( postUrl ) ), |
There was a problem hiding this comment.
That pattern matcher wasn't working with wp-env; maybe it could work with pretty permalinks, but we can't ensure that. I found this pattern to be the safe solution for now.
I usually check in UI Mode if requests were successfully intercepted.
Screenshot
Mamaduka
reviewed
Feb 9, 2024
Comment on lines
299
to
303
| await expect( | ||
| page | ||
| .getByRole( 'region', { name: 'Editor top bar' } ) | ||
| .getByRole( 'button', { name: 'Save draft' } ) | ||
| ).toBeEnabled(); |
There was a problem hiding this comment.
The button isn't restored when making changes in flight. I'm not sure if this is a regression. The behavior can be reproduced manually by throttling the network via DevTools.
Mamaduka
requested review from
Mamaduka and
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
|
I've made a few minor changes/fixes. The migration looks good to land, IMO. @WunderBart, if you have time. Do you mind providing a second opinion and ✅? |
|
Flaky tests detected in a23241e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7840952010
|
Mamaduka
approved these changes
Feb 13, 2024
aristath
added a commit
that referenced
this pull request
Feb 13, 2024
* trunk: (273 commits) Remove preffered style variations legacy support (#58930) Style theme variations: add property extraction and merge utils (#58803) Migrate `change-detection` to Playwright (#58767) Update Changelog for 17.6.6 Docs: Clarify the status of the wp-block-styles theme support, and its intent (#58915) Use `data_wp_context` helper in core blocks and remove `data-wp-interactive` object (#58943) Try double enter for details block. (#58903) Template revisions API: move from experimental to compat/6.4 (#58920) Editor: Remove inline toolbar preference (#58945) Clean up link control CSS. (#58934) Font Library: Show error message when no fonts found to install (#58914) Block Bindings: lock editing of blocks by default (#58787) Editor: Remove the 'all' rendering mode (#58935) Pagination Numbers: Add `data-wp-key` to pagination numbers if enhanced pagination is enabled (#58189) Close link preview if collapsed selection when creating link (#58896) Fix incorrect useAnchor positioning when switching from virtual to rich text elements (#58900) Upgrade Floating UI packages, fix nested iframe positioning bug (#58932) Site editor: fix start patterns store selector (#58813) Revert "Rich text: pad multiple spaces through en/em replacement (#56341)" (#58792) Documentation: Clarify the performance reference commit and how to pick it (#58927) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
change-detection.test.jse2e tests to Playwright.Why?
See #38851.
Testing Instructions