Font Library: address feedback from wordpress-develop#6027

[creativecoder]

What?

Addresses initial feedback from WordPress/wordpress-develop#6027

• Removes unneeded comment in wp_get_font_dir
• Move font collection slug check to immediately after slug is assigned
• Removes extra line in WP_Font_Library::$collections docblock
• Fix translators comment indentation
• Remove unneeded colon from error message
• Use is_collection_registered in get_font_collection
• Use variable for font_dir so function isn't called repeatedly within loop
• Adds empty line before the return of WP_Font_Collection::get_data
• Uses static closure in font collection sanitization schema

Why?

We're updating the code in Gutenberg first, and then updating the wordpress-develop PR to keep the Gutenberg and proposed Core code in sync.

Testing Instructions

No functional changes. Check that phpunit tests pass and feature continues to work as expected.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: grantmkin, hellofromtonya.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: creativecoder <[email protected]>
Co-authored-by: hellofromtonya <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php
❔ lib/compat/wordpress-6.5/fonts/fonts.php

[hellofromtonya]

This PR captures all of the feedback in Core's PR.

The only exception: whether to assign a WP_Error for the font collection slug mismatch in its constructor. But this is a discussion and not yet ready to be actioned. Thinking the discussion could be a follow-up in Core once there's consensus and if changes are needed.

The PR LGTM 👍

[github-actions]

Flaky tests detected in 4d8472a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7790546483
📝 Reported issues:

• [Flaky Test] should select with shift + click #48390 in /test/e2e/specs/editor/various/multi-block-selection.spec.js