Block Hooks: Try to make insertion into Navigation block work on WP 6.4 #58508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @tjcafferkey |
ockham
changed the title
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/block-hooks.php ❔ lib/load.php |
16 tasks
|
I’m sure it can be closed at this stage. Gutenberg should not support WP 6.4 anymore after WP 6.6 is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Try to make hooked blocks insertion into Navigation block work on WP 6.4.
Why?
We had to disable this on WP 6.4 and below, as some required functionality is missing there. That means that the feature is currently only working when running the GB plugin on Core
trunk.How?
Not great. I thought I could get this to work by clever usage of the
hooked_block_typesfilter, but it doesn't really look like it:https://github.com/WordPress/gutenberg/compare/add/block-hooks-6-5-compat-layer-for-nav-block?expand=1#diff-5369312b3be3a2f9a55c7cc974336247b6e79105e869f241f99e64e2ea1ac756R35-R39
Testing Instructions
TBD, but basically: Test on WP 6.4, and on
trunk.