Add support for transform and letter spacing controls in Global Styles > Typography > Elements #58142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
[Type] Feature
MaggieCabrera
commented
Jan 23, 2024
| @@ -56,8 +56,13 @@ function filterElementBlockSupports( blockSupports, name, element ) { | |||
| if ( | |||
| support === 'textTransform' && | |||
| ! name && | |||
| ! [ 'heading', 'h1', 'h2', 'h3', 'h4', 'h5', 'h6' ].includes( | |||
| element | |||
| ! ( | |||
There was a problem hiding this comment.
I think we should just allow it for all of them
|
I guess this is not going to be common and it's already an issue for headings that allow this transform, but just pointing out that the little preview of the elements is showing the dramatic letter spacing that I used for testing this: 
|
|
Size Change: -1.68 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
I think it's fine to keep in for now, perhaps explore later. Links for example don't get all the treatments. They should probably have less even (just inherit from text). |
|
Very nice! Is there context on why these were omitted originally? cc @WordPress/gutenberg-design |
|
Flaky tests detected in a89e47d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7630125743
|
|
None that I'm aware of, seems like it may have been forgotten in that space after the toolspanel afforded additional controls without the burden of a long inspector. |
we could apply them for everything except the links. |
westonruter
added a commit
that referenced
this pull request
Jan 26, 2024
…zy-hydration * origin/trunk: (47 commits) Interactivity API: Break up long hydration task in interactivity init (#58227) Add supports.interactivity to Query block (#58316) Font Library: Make notices more consistent (#58180) Fix Global styles text settings bleeding into placeholder component (#58303) Fix the position and size of the Options menu, (#57515) DataViews: Fix safari grid row height issue (#58302) Try a fix (#58282) Navigation Submenu Block: Make block name affect list view (#58296) Apply custom scroll style to fixed header block toolbar (#57444) Add support for transform and letter spacing controls in Global Styles > Typography > Elements (#58142) DataViews: Fix table view cell wrapper and BlockPreviews (#58062) Workflows: Add 'Technical Prototype' to the type-related labels list (#58163) Block Editor: Optimize the 'useBlockDisplayTitle' hook (#58250) Remove noahtallen from .wp-env codeowners (#58283) Global styles revisions: fix is-selected rules from affecting other areas of the editor (#58228) Try: Disable text selection for post content placeholder block. (#58169) Remove `template-only` mode from editor and edit-post packages (#57700) Refactored download/upload logic to support font faces with multiple src assets (#58216) Components: Expand theming support in COLORS (#58097) Implementing new UX for invoking rich text Link UI (#57986) ...
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #58080
Adds
textTransformandletterSpacingsupports to the text, caption and button elementsWhy?
It makes sense for these elements to have these controls
How?
I just added the elements to the exception in the filter, but I wonder if we could just remove the exception altogether since we are basically adding them to everything except
cite. What do you think @richtabor ?Testing Instructions
On a block theme, go to Global styles > Typography > Elements
Change try setting the buttons to uppercase and give them some letter spacing
The changes should be reflected on the editor and the frontend.
Testing Instructions for Keyboard
Screenshots or screencast