Block Hooks: Fix toggle #57956
Merged
Block Hooks: Fix toggle #57956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Bug
ockham
commented
Jan 18, 2024
| @@ -83,7 +83,7 @@ function BlockHooksControlPure( { name, clientId } ) { | |||
| } | |||
|
|
|||
| const hookedBlock = candidates?.find( | |||
| ( candidate ) => name === candidate.name | |||
| ( candidate ) => candidate.name === block.name | |||
There was a problem hiding this comment.
In case of before and after insertion, all children of the current anchor block's parent are candidates; we need to compare them to the hooked block's name (block.name), rather than the anchor block's name (which will always be true, as the anchor block is of course also a child of its own parent).
|
Size Change: +4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 90e112d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7568838568
|
Mamaduka
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the Block Hooks toggle (broken by #56862 (comment)).
Why?
After #56862, the Block Hooks toggle stopped working properly:
If you had one instance of a hooked block that was inserted
beforeofafterits anchor block in your template, it became impossible to use the toggle to remove the block -- it would just stay enabled. (You could only delete the block manually.)If you had additional instances of hooked blocks, the behavior would be even weirder: Even if you deleted the hooked block, the toggle would stay enabled.
How?
By fixing a check that was using the wrong variable to compare to.
Testing Instructions
To reproduce the issue (on
trunk):Now manually delete the other Like Button (in the Comments Template block) to test the scenario with only one hooked block.
To verify the fix
On this branch, go through the above instructions again. Verify that the buggy behavior (marked ❌ ) has been fixed.
Note that importantly, some of the "fixed" behavior is still counter-intuitive: If both instances of the Like Button block (i.e. below Post Content and in Comment Template) were present in the first place, disabling the Like Button toggle for the Post Content will cause the toggle to disappear altogether. This is currently expected behavior; it will be fixed separately by #57928.
Screenshots or screencast