Image Block: Make block name affect list view #57955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
3 tasks
|
Size Change: +21 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
artemiomorales and
michalczaplinski
as code owners
|
@ntsekouras Thanks for the review! |
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #57954
What?
This PR fixes an issue where the block name is not reflected in the list view for the Image block.
Before
After
Why?
If that block has opted into
__experimentLabel, the list view will display the default block name unless we explicitly returnmetadata.namewhen the context islist-view.For a more detailed analysis, please refer to #57954.
Testing Instructions