Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the iframe markup of the embed video in the Quick Start Guide #57857

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Jan 15, 2024

This PR is a follow-up to #57834. The implementation in that PR did not work since the iframe was stripped when the doc was published.

However, this can be solved by enabling some Jetpack functionality that @adamwoodnz discovered here: #57834 (comment)

Therefore, this PR removed the unnecessary wrapper div and inline styles from the iframe.

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Jan 15, 2024
@ndiego ndiego self-assigned this Jan 15, 2024
Copy link

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave this mostly as is:

docs/getting-started/quick-start-guide.md Outdated Show resolved Hide resolved
@ndiego ndiego changed the title Use [youtube] shortcode to embed the video in the Quick Start Guide Fix the iframe markup of the embed video in the Quick Start Guide Jan 15, 2024
Copy link

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ndiego ndiego enabled auto-merge (squash) January 15, 2024 20:46
@ndiego ndiego merged commit 71da85a into trunk Jan 15, 2024
55 checks passed
@ndiego ndiego deleted the docs/fix-youtube-embed-in-quick-start-guide branch January 15, 2024 22:12
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants